Date: Wed, 7 Dec 2016 16:52:48 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Stuart Yoder <stuart.yoder@nxp.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
        agraf@suse.de, arnd@arndb.de, leoyang.li@nxp.com,
        ioana.ciornei@nxp.com, catalin.horghidan@nxp.com,
        laurentiu.tudor@nxp.com, ruxandra.radulescu@nxp.com
Subject: Re: [PATCH v3 1/9] staging: fsl-mc: move bus driver out of staging
Message-ID: <20161207155248.GA11794@kroah.com>
References: <1480632094-3621-1-git-send-email-stuart.yoder@nxp.com>
 <1480632094-3621-2-git-send-email-stuart.yoder@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1480632094-3621-2-git-send-email-stuart.yoder@nxp.com>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1228
Lines: 28

On Thu, Dec 01, 2016 at 04:41:26PM -0600, Stuart Yoder wrote:
> Move the source files out of staging into their final locations:
>   -include files in drivers/staging/fsl-mc/include go to include/linux/fsl
>   -irq-gic-v3-its-fsl-mc-msi.c goes to drivers/irqchip
>   -source in drivers/staging/fsl-mc/bus goes to drivers/bus/fsl-mc
>   -README.txt, providing and overview of DPAA goes to
>    Documentation/dpaa2/overview.txt
>   -update MAINTAINERS with new location
> 
> Delete other remaining staging files-- Makefile, Kconfig, TODO

Ok, given that I haven't ever reviewed this code, I had a few questions
that I couldn't easily figure out by looking at your code:
	- what is the lifecycle of your 'struct device' usage?  Who
	  creates it, who frees it, and who accesses it?
	- do you have any Documentation/ABI entries?
	- root_dprc_count, why are you using an atomic variable for
	  this?  What is it for other than "look, I'm running!"?
	- don't call pr_info() in fsl_mc_bus_driver_init(), no need to
	  say anything if all goes well.  Same goes with random
	  dev_info() calls, please remove.

That's good enough for now, I think the answer to the first question is
going to cause more to come out :)

thanks,

greg k-h