Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753538AbcLGQ27 (ORCPT ); Wed, 7 Dec 2016 11:28:59 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:22743 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752186AbcLGQ25 (ORCPT ); Wed, 7 Dec 2016 11:28:57 -0500 Subject: Re: [net-next][PATCH v2 10/18] RDS: IB: track and log active side endpoint in connection To: David Miller References: <1481083316-11648-1-git-send-email-santosh.shilimkar@oracle.com> <1481083316-11648-11-git-send-email-santosh.shilimkar@oracle.com> <20161207.105318.2143064665652853543.davem@davemloft.net> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Santosh Shilimkar Organization: Oracle Corporation Message-ID: <7079ed0b-c05f-5223-7216-6a75025b3205@oracle.com> Date: Wed, 7 Dec 2016 08:29:14 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20161207.105318.2143064665652853543.davem@davemloft.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 895 Lines: 37 On 12/7/2016 7:53 AM, David Miller wrote: > From: Santosh Shilimkar > Date: Tue, 6 Dec 2016 20:01:48 -0800 > >> @@ -181,6 +181,9 @@ struct rds_ib_connection { >> >> /* Batched completions */ >> unsigned int i_unsignaled_wrs; >> + >> + /* Endpoint role in connection */ >> + int i_active_side; >> }; >> > ... >> @@ -685,6 +686,7 @@ int rds_ib_cm_initiate_connect(struct rdma_cm_id *cm_id) >> if (ic->i_cm_id == cm_id) >> ret = 0; >> } >> + ic->i_active_side = true; >> return ret; >> } >> >> @@ -859,6 +861,7 @@ void rds_ib_conn_path_shutdown(struct rds_conn_path *cp) >> ic->i_sends = NULL; >> vfree(ic->i_recvs); >> ic->i_recvs = NULL; >> + ic->i_active_side = false; >> } >> >> int rds_ib_conn_alloc(struct rds_connection *conn, gfp_t gfp) > > Use type "bool", not "int", for true/false values. > OK. Will fix it. Regards, Santosh