Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753251AbcLGSJR (ORCPT ); Wed, 7 Dec 2016 13:09:17 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:36792 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752625AbcLGSJQ (ORCPT ); Wed, 7 Dec 2016 13:09:16 -0500 Date: Wed, 07 Dec 2016 13:09:14 -0500 (EST) Message-Id: <20161207.130914.1091695245299713548.davem@davemloft.net> To: niklas.cassel@axis.com Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com, niklass@axis.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: stmmac: do not call phy_ethtool_ksettings_set from atomic context From: David Miller In-Reply-To: <1481032035-19018-1-git-send-email-niklass@axis.com> References: <1481032035-19018-1-git-send-email-niklass@axis.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 07 Dec 2016 09:09:53 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 649 Lines: 17 From: Niklas Cassel Date: Tue, 6 Dec 2016 14:47:15 +0100 > From: Niklas Cassel > > From what I can tell, spin_lock(&priv->lock) is not needed, since the > phy_ethtool_ksettings_set call is not given the priv struct. > > phy_start_aneg takes the phydev->lock. Calls to phy_adjust_link > from phy_state_machine also takes the phydev->lock. ... > Signed-off-by: Niklas Cassel Applied, but please always be explicit about what tree you are targetting this patch by properly annotating for it in your Subject line. In this case that would be "Subject: [PATCH net-next] ..."