Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753438AbcLGSvd (ORCPT ); Wed, 7 Dec 2016 13:51:33 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:37484 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752396AbcLGSvc (ORCPT ); Wed, 7 Dec 2016 13:51:32 -0500 Date: Wed, 07 Dec 2016 13:51:27 -0500 (EST) Message-Id: <20161207.135127.789629809982860453.davem@davemloft.net> To: dave.taht@gmail.com Cc: Jason@zx2c4.com, netdev@vger.kernel.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, wireguard@lists.zx2c4.com Subject: Re: Misalignment, MIPS, and ip_hdr(skb)->version From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 07 Dec 2016 09:52:07 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 529 Lines: 11 From: Dave Taht Date: Wed, 7 Dec 2016 10:47:16 -0800 > https://git.lede-project.org/?p=openwrt/source.git;a=blob;f=target/linux/ar71xx/patches-4.4/910-unaligned_access_hacks.patch;h=b4b749e4b9c02a74a9f712a2740d63e554de5c64;hb=ee53a240ac902dc83209008a2671e7fdcf55957a It's so much better to analyze properly where the misalignment comes from and address it at the source, as we have for various cases that trip up Sparc too. Marking structures "packed" is going to kill performance and is not the answer.