Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933354AbcLGWqc (ORCPT ); Wed, 7 Dec 2016 17:46:32 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:54864 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932583AbcLGWqa (ORCPT ); Wed, 7 Dec 2016 17:46:30 -0500 Date: Wed, 7 Dec 2016 14:46:28 -0800 From: Christoph Hellwig To: Keith Busch Cc: Dan Streetman , Jens Axboe , Dan Streetman , linux-kernel , linux-nvme@lists.infradead.org Subject: Re: [PATCH] nvme: use the correct msix vector for each queue Message-ID: <20161207224627.GA16018@infradead.org> References: <20161207220348.8572-1-ddstreet@ieee.org> <20161207224414.GE22478@localhost.localdomain> <20161207224941.GA25959@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161207224941.GA25959@localhost.localdomain> User-Agent: Mutt/1.6.1 (2016-04-27) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 669 Lines: 15 On Wed, Dec 07, 2016 at 05:49:42PM -0500, Keith Busch wrote: > I'm just saying that blk-mq's hctx mapping will end up choosing a queue > who's vector is mapped to a different CPU, and we don't want that. Right. For 4.10 we could use the pci_alloc_irq_vectors_affinity helper to set away a pre_vector IFF we want a separate vector for the admin queue. > We are currently sharing the first IO queue's interrupt vector with > the admin queue's on purpose. Are you saying there's something wrong > with that? But given that the sharing was done intentionally and we had a long discussion on it back then there should be no real reason to change the assignment in NVMe.