Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933588AbcLGXZg (ORCPT ); Wed, 7 Dec 2016 18:25:36 -0500 Received: from outbound-smtp08.blacknight.com ([46.22.139.13]:49904 "EHLO outbound-smtp08.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932983AbcLGXZf (ORCPT ); Wed, 7 Dec 2016 18:25:35 -0500 Date: Wed, 7 Dec 2016 23:25:31 +0000 From: Mel Gorman To: Eric Dumazet Cc: Andrew Morton , Christoph Lameter , Michal Hocko , Vlastimil Babka , Johannes Weiner , Jesper Dangaard Brouer , Joonsoo Kim , Linux-MM , Linux-Kernel Subject: Re: [PATCH] mm: page_alloc: High-order per-cpu page allocator v7 Message-ID: <20161207232531.fxqdgrweilej5gs6@techsingularity.net> References: <20161207101228.8128-1-mgorman@techsingularity.net> <1481137249.4930.59.camel@edumazet-glaptop3.roam.corp.google.com> <20161207194801.krhonj7yggbedpba@techsingularity.net> <1481141424.4930.71.camel@edumazet-glaptop3.roam.corp.google.com> <20161207211958.s3ymjva54wgakpkm@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20161207211958.s3ymjva54wgakpkm@techsingularity.net> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1557 Lines: 28 On Wed, Dec 07, 2016 at 09:19:58PM +0000, Mel Gorman wrote: > At small packet sizes on localhost, I see relatively low page allocator > activity except during the socket setup and other unrelated activity > (khugepaged, irqbalance, some btrfs stuff) which is curious as it's > less clear why the performance was improved in that case. I considered > the possibility that it was cache hotness of pages but that's not a > good fit. If it was true then the first test would be slow and the rest > relatively fast and I'm not seeing that. The other side-effect is that > all the high-order pages that are allocated at the start are physically > close together but that shouldn't have that big an impact. So for now, > the gain is unexplained even though it happens consistently. > Further investigation led me to conclude that the netperf automation on my side had some methodology errors that could account for an artifically low score in some cases. The netperf automation is years old and would have been developed against a much older and smaller machine which may be why I missed it until I went back looking at exactly what the automation was doing. Minimally in a server/client test on remote maching there was potentially higher packet loss than is acceptable. This would account why some machines "benefitted" while others did not -- there would be boot to boot variations that some machines happened to be "lucky". I believe I've corrected the errors, discarded all the old data and scheduled a rest to see what falls out. -- Mel Gorman SUSE Labs