Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753360AbcLGXqx (ORCPT ); Wed, 7 Dec 2016 18:46:53 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:60416 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752156AbcLGXqw (ORCPT ); Wed, 7 Dec 2016 18:46:52 -0500 Date: Wed, 7 Dec 2016 23:46:39 +0000 From: Al Viro To: Oleg Drokin Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andreas Dilger , James Simmons , Linux Kernel Mailing List , Lustre Development List Subject: Re: [PATCH 0/8] Sparse warning fixes in Lustre. Message-ID: <20161207234639.GU1555@ZenIV.linux.org.uk> References: <1481150494-1853127-1-git-send-email-green@linuxhacker.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1481150494-1853127-1-git-send-email-green@linuxhacker.ru> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 466 Lines: 9 On Wed, Dec 07, 2016 at 05:41:26PM -0500, Oleg Drokin wrote: > This set of fixes aims at sparse warnings. Speaking of the stuff sparse catches there: class_process_proc_param(). I've tried to describe what I think of that Fine Piece Of Software several times, but I had to give up - my command of obscenity is not up to the task, neither in English nor in Russian. Please, take it out. Preferably - along with the ->ldo_process_config()/->process_config() thing.