Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933733AbcLHAXr (ORCPT ); Wed, 7 Dec 2016 19:23:47 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:47336 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932478AbcLHAXp (ORCPT ); Wed, 7 Dec 2016 19:23:45 -0500 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 466BF606DB Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Wed, 7 Dec 2016 16:23:43 -0800 From: Stephen Boyd To: Pan Bian Cc: Michael Turquette , patches@opensource.wolfsonmicro.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] clk: clk-wm831x: fix a logic error Message-ID: <20161208002343.GG5423@codeaurora.org> References: <1480573545-18588-1-git-send-email-bianpan2016@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1480573545-18588-1-git-send-email-bianpan2016@163.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 474 Lines: 14 On 12/01, Pan Bian wrote: > Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188561. Function > wm831x_clkout_is_prepared() returns "true" when it fails to read > CLOCK_CONTROL_1. "true" means the device is already prepared. So > return "true" on the read failure seems improper. > > Signed-off-by: Pan Bian > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project