Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933909AbcLHAZh (ORCPT ); Wed, 7 Dec 2016 19:25:37 -0500 Received: from casper.infradead.org ([85.118.1.10]:55598 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753331AbcLHAZg (ORCPT ); Wed, 7 Dec 2016 19:25:36 -0500 Date: Thu, 8 Dec 2016 00:24:42 +0000 (GMT) From: James Simmons To: Oleg Drokin cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andreas Dilger , Linux Kernel Mailing List , Lustre Development List Subject: Re: [PATCH 7/8] staging/lustre: Move lov_read_and_clear_async_rc declaration In-Reply-To: <1481150494-1853127-8-git-send-email-green@linuxhacker.ru> Message-ID: References: <1481150494-1853127-1-git-send-email-green@linuxhacker.ru> <1481150494-1853127-8-git-send-email-green@linuxhacker.ru> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161208_002443_864606_72917A09 X-CRM114-Status: GOOD ( 11.66 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 NO_RELAYS Informational: message was not relayed via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1915 Lines: 51 > Move it to obd.h, so that it's included from both the users and > the actual definition, making sure they never get out of sync. > This also silences a sparse warning. Reviewed-by: James Simmons > Signed-off-by: Oleg Drokin > --- > drivers/staging/lustre/lustre/include/obd.h | 3 +++ > drivers/staging/lustre/lustre/llite/vvp_internal.h | 2 -- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/include/obd.h b/drivers/staging/lustre/lustre/include/obd.h > index 0f48e9c..1839f4f 100644 > --- a/drivers/staging/lustre/lustre/include/obd.h > +++ b/drivers/staging/lustre/lustre/include/obd.h > @@ -43,6 +43,7 @@ > #include "lustre_fld.h" > #include "lustre_handles.h" > #include "lustre_intent.h" > +#include "cl_object.h" > > #define MAX_OBD_DEVICES 8192 > > @@ -76,6 +77,8 @@ static inline void loi_init(struct lov_oinfo *loi) > struct lov_stripe_md; > struct obd_info; > > +int lov_read_and_clear_async_rc(struct cl_object *clob); > + > typedef int (*obd_enqueue_update_f)(void *cookie, int rc); > > /* obd info for a particular level (lov, osc). */ > diff --git a/drivers/staging/lustre/lustre/llite/vvp_internal.h b/drivers/staging/lustre/lustre/llite/vvp_internal.h > index c60d041..f40fd7f 100644 > --- a/drivers/staging/lustre/lustre/llite/vvp_internal.h > +++ b/drivers/staging/lustre/lustre/llite/vvp_internal.h > @@ -301,8 +301,6 @@ static inline struct vvp_lock *cl2vvp_lock(const struct cl_lock_slice *slice) > # define CLOBINVRNT(env, clob, expr) \ > ((void)sizeof(env), (void)sizeof(clob), (void)sizeof(!!(expr))) > > -int lov_read_and_clear_async_rc(struct cl_object *clob); > - > int vvp_io_init(const struct lu_env *env, struct cl_object *obj, > struct cl_io *io); > int vvp_io_write_commit(const struct lu_env *env, struct cl_io *io); > -- > 2.7.4 > >