Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934082AbcLHA1e (ORCPT ); Wed, 7 Dec 2016 19:27:34 -0500 Received: from casper.infradead.org ([85.118.1.10]:55758 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932966AbcLHA1d (ORCPT ); Wed, 7 Dec 2016 19:27:33 -0500 Date: Thu, 8 Dec 2016 00:27:27 +0000 (GMT) From: James Simmons To: Oleg Drokin cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andreas Dilger , Linux Kernel Mailing List , Lustre Development List Subject: Re: [PATCH 8/8] staging/lustre/ptlrpc: Move nrs_conf_fifo extern to a header In-Reply-To: <1481150494-1853127-9-git-send-email-green@linuxhacker.ru> Message-ID: References: <1481150494-1853127-1-git-send-email-green@linuxhacker.ru> <1481150494-1853127-9-git-send-email-green@linuxhacker.ru> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161208_002730_159082_C5AD22CD X-CRM114-Status: GOOD ( 10.72 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 NO_RELAYS Informational: message was not relayed via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1730 Lines: 44 > This avoids having an extern definition in a C file which is bad, > and also silences sparse complaint as well. > > Signed-off-by: Oleg Drokin Reviewed-by: James Simmons > --- > drivers/staging/lustre/lustre/ptlrpc/nrs.c | 3 --- > drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h | 3 +++ > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/ptlrpc/nrs.c b/drivers/staging/lustre/lustre/ptlrpc/nrs.c > index 7b6ffb1..ef19dbe 100644 > --- a/drivers/staging/lustre/lustre/ptlrpc/nrs.c > +++ b/drivers/staging/lustre/lustre/ptlrpc/nrs.c > @@ -1559,9 +1559,6 @@ int ptlrpc_nrs_policy_control(const struct ptlrpc_service *svc, > return rc; > } > > -/* ptlrpc/nrs_fifo.c */ > -extern struct ptlrpc_nrs_pol_conf nrs_conf_fifo; > - > /** > * Adds all policies that ship with the ptlrpc module, to NRS core's list of > * policies \e nrs_core.nrs_policies. > diff --git a/drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h b/drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h > index e0f859c..8e6a805 100644 > --- a/drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h > +++ b/drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h > @@ -226,6 +226,9 @@ struct ptlrpc_nrs_policy *nrs_request_policy(struct ptlrpc_nrs_request *nrq) > sizeof(NRS_LPROCFS_QUANTUM_NAME_REG __stringify(LPROCFS_NRS_QUANTUM_MAX) " " \ > NRS_LPROCFS_QUANTUM_NAME_HP __stringify(LPROCFS_NRS_QUANTUM_MAX)) > > +/* ptlrpc/nrs_fifo.c */ > +extern struct ptlrpc_nrs_pol_conf nrs_conf_fifo; > + > /* recovd_thread.c */ > > int ptlrpc_expire_one_request(struct ptlrpc_request *req, int async_unlink); > -- > 2.7.4 > >