Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934101AbcLHA2b (ORCPT ); Wed, 7 Dec 2016 19:28:31 -0500 Received: from casper.infradead.org ([85.118.1.10]:55824 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932966AbcLHA23 (ORCPT ); Wed, 7 Dec 2016 19:28:29 -0500 Date: Thu, 8 Dec 2016 00:28:28 +0000 (GMT) From: James Simmons To: Oleg Drokin cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andreas Dilger , Linux Kernel Mailing List , Lustre Development List Subject: Re: [PATCH 6/8] staging/lustre: Declare lu_context/session_tags_default In-Reply-To: <1481150494-1853127-7-git-send-email-green@linuxhacker.ru> Message-ID: References: <1481150494-1853127-1-git-send-email-green@linuxhacker.ru> <1481150494-1853127-7-git-send-email-green@linuxhacker.ru> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161208_002828_163136_F253CD64 X-CRM114-Status: GOOD ( 12.09 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 NO_RELAYS Informational: message was not relayed via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1925 Lines: 52 > Make the declaration in a header, not as an extern in a C file, > that is frowned upon. > This also makes sparse a little bit more happy. > Reviewed-by: James Simmons > Signed-off-by: Oleg Drokin > --- > drivers/staging/lustre/lustre/include/lu_object.h | 3 +++ > drivers/staging/lustre/lustre/obdclass/cl_object.c | 3 +-- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/include/lu_object.h b/drivers/staging/lustre/lustre/include/lu_object.h > index 260643e..69b2812 100644 > --- a/drivers/staging/lustre/lustre/include/lu_object.h > +++ b/drivers/staging/lustre/lustre/include/lu_object.h > @@ -1326,5 +1326,8 @@ void lu_buf_realloc(struct lu_buf *buf, size_t size); > int lu_buf_check_and_grow(struct lu_buf *buf, size_t len); > struct lu_buf *lu_buf_check_and_alloc(struct lu_buf *buf, size_t len); > > +extern __u32 lu_context_tags_default; > +extern __u32 lu_session_tags_default; > + > /** @} lu */ > #endif /* __LUSTRE_LU_OBJECT_H */ > diff --git a/drivers/staging/lustre/lustre/obdclass/cl_object.c b/drivers/staging/lustre/lustre/obdclass/cl_object.c > index f5d4e23..703cb67 100644 > --- a/drivers/staging/lustre/lustre/obdclass/cl_object.c > +++ b/drivers/staging/lustre/lustre/obdclass/cl_object.c > @@ -54,6 +54,7 @@ > #include > #include "../../include/linux/libcfs/libcfs_hash.h" /* for cfs_hash stuff */ > #include "../include/cl_object.h" > +#include "../include/lu_object.h" > #include "cl_internal.h" > > static struct kmem_cache *cl_env_kmem; > @@ -61,8 +62,6 @@ static struct kmem_cache *cl_env_kmem; > /** Lock class of cl_object_header::coh_attr_guard */ > static struct lock_class_key cl_attr_guard_class; > > -extern __u32 lu_context_tags_default; > -extern __u32 lu_session_tags_default; > /** > * Initialize cl_object_header. > */ > -- > 2.7.4 > >