Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933402AbcLHBVD (ORCPT ); Wed, 7 Dec 2016 20:21:03 -0500 Received: from mail-oi0-f68.google.com ([209.85.218.68]:33731 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932967AbcLHBVC (ORCPT ); Wed, 7 Dec 2016 20:21:02 -0500 MIME-Version: 1.0 In-Reply-To: <1481131804.2404.10.camel@intel.com> References: <1481096614-25295-1-git-send-email-zhouzhouyi@gmail.com> <1481131804.2404.10.camel@intel.com> From: Zhouyi Zhou Date: Thu, 8 Dec 2016 09:21:00 +0800 Message-ID: Subject: Re: [PATCH 1/1] ixgbe: fcoe: return value of skb_linearize should be handled To: Jeff Kirsher Cc: intel-wired-lan , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Zhouyi Zhou Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 908 Lines: 21 Thanks Jeff for your advice, Sorry for the my innocence as a Linux kernel rookie. Zhouyi On Thu, Dec 8, 2016 at 1:30 AM, Jeff Kirsher wrote: > On Wed, 2016-12-07 at 15:43 +0800, Zhouyi Zhou wrote: >> Signed-off-by: Zhouyi Zhou >> Reviewed-by: Cong Wang >> Reviewed-by: Yuval Shaia >> Reviewed-by: Eric Dumazet >> --- >> drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c | 6 +++++- >> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 +-- >> 2 files changed, 6 insertions(+), 3 deletions(-) > > Did Cong, Yuval and Eric give their Reviewed-by offline? I see they made > comments and suggests, but never saw them actually give you their Reviewed- > by. You cannot automatically add their Reviewed-by, Signed-off-by, etc > just because someone provides feedback on your patch.