Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753369AbcLHBWX (ORCPT ); Wed, 7 Dec 2016 20:22:23 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:35521 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752343AbcLHBWW (ORCPT ); Wed, 7 Dec 2016 20:22:22 -0500 Date: Wed, 7 Dec 2016 17:22:18 -0800 From: Dmitry Torokhov To: Nick Dyer Cc: Andrew Duggan , Chris Healy , Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: synaptics-rmi4 - fix debug for sensor clip Message-ID: <20161208012218.GA27638@dtor-ws> References: <1480899881-31425-1-git-send-email-nick@shmanahar.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1480899881-31425-1-git-send-email-nick@shmanahar.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1311 Lines: 43 On Mon, Dec 05, 2016 at 01:04:41AM +0000, Nick Dyer wrote: > The debug would only ever output zero for the clip information. > > Signed-off-by: Nick Dyer Applied, thank you. > --- > > drivers/input/rmi4/rmi_f12.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/input/rmi4/rmi_f12.c b/drivers/input/rmi4/rmi_f12.c > index 8c5360c..e35c64b 100644 > --- a/drivers/input/rmi4/rmi_f12.c > +++ b/drivers/input/rmi4/rmi_f12.c > @@ -71,10 +71,6 @@ static int rmi_f12_read_sensor_tuning(struct f12_data *f12) > u8 buf[15]; > int pitch_x = 0; > int pitch_y = 0; > - int clip_x_low = 0; > - int clip_x_high = 0; > - int clip_y_low = 0; > - int clip_y_high = 0; > int rx_receivers = 0; > int tx_receivers = 0; > int sensor_flags = 0; > @@ -127,7 +123,8 @@ static int rmi_f12_read_sensor_tuning(struct f12_data *f12) > } > > rmi_dbg(RMI_DEBUG_FN, &fn->dev, "%s: x low: %d x high: %d y low: %d y high: %d\n", > - __func__, clip_x_low, clip_x_high, clip_y_low, clip_y_high); > + __func__, sensor->axis_align.clip_x_low, sensor->axis_align.clip_x_high, > + sensor->axis_align.clip_y_low, sensor->axis_align.clip_y_high); > > if (rmi_register_desc_has_subpacket(item, 3)) { > rx_receivers = buf[offset]; > -- > 2.7.4 > -- Dmitry