Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934075AbcLHCLa convert rfc822-to-8bit (ORCPT ); Wed, 7 Dec 2016 21:11:30 -0500 Received: from szxga02-in.huawei.com ([45.249.212.188]:2373 "EHLO dggrg02-dlp.huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753523AbcLHCL2 (ORCPT ); Wed, 7 Dec 2016 21:11:28 -0500 From: "Gonglei (Arei)" To: Sam Ravnborg CC: kbuild test robot , "davem@davemloft.net" , "kbuild-all@01.org" , "linux-kernel@vger.kernel.org" , "qemu-devel@nongnu.org" , "virtio-dev@lists.oasis-open.org" , "virtualization@lists.linux-foundation.org" , "linux-crypto@vger.kernel.org" , Luonengjun , "mst@redhat.com" , "stefanha@redhat.com" , "Huangweidong (C)" , "Wubin (H)" , "xin.zeng@intel.com" , Claudio Fontana , "herbert@gondor.apana.org.au" , "pasic@linux.vnet.ibm.com" , "Zhoujian (jay, Euler)" , "Hanweidong (Randy)" , "arei.gonglei@hotmail.com" , "cornelia.huck@de.ibm.com" , "Xuquan (Quan Xu)" , longpeng , "Wanzongshun (Vincent)" Subject: RE: [PATCH v5 1/1] crypto: add virtio-crypto driver Thread-Topic: [PATCH v5 1/1] crypto: add virtio-crypto driver Thread-Index: AQHSS8/uqslEzhMJvkOJ/Inwv8bRTqD2kZMAgAIf2eCAA7+YgIAA5h9g Date: Thu, 8 Dec 2016 02:10:19 +0000 Message-ID: <33183CC9F5247A488A2544077AF19020DA156A4C@DGGEMA505-MBX.china.huawei.com> References: <1480595945-63656-2-git-send-email-arei.gonglei@huawei.com> <201612041032.loAEWLIy%fengguang.wu@intel.com> <33183CC9F5247A488A2544077AF19020DA1528DE@DGGEMA505-MBX.china.huawei.com> <20161207202039.GA27878@ravnborg.org> In-Reply-To: <20161207202039.GA27878@ravnborg.org> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.177.18.62] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090204.5848C119.039A,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=169.254.1.226, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: fe1c3021b6ee95f14b93e8c7d4943555 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 884 Lines: 29 Hi Sam, > > Subject: Re: [PATCH v5 1/1] crypto: add virtio-crypto driver > > On Mon, Dec 05, 2016 at 03:12:52AM +0000, Gonglei (Arei) wrote: > > I don't think the root cause of those warnings are introduced by virtio-crypto > driver. > > > > What's your opinion? Sam and David? > > Root cause here is that arch/sparc/include/asm/topology_64.h > references cpu_data without including arch/sparc/include/asm/cpudata.h > > I think other architectures pull in the dependency from > either smp.h or they have it topology.h. > > The easy fix would be to include cpudata.h in > arch/sparc/include/asm/topology_64.h. > And that should also be a correct fix. > > Could you include this in your patch-set and build test it? > Sure, I can add this one at the head of my patch set, but because I haven't sparc environment, so it depends on the kbuild test robot to test. Thanks, -Gonglei