Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753590AbcLHGiU (ORCPT ); Thu, 8 Dec 2016 01:38:20 -0500 Received: from mail-cys01nam02on0078.outbound.protection.outlook.com ([104.47.37.78]:51962 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753440AbcLHGiQ (ORCPT ); Thu, 8 Dec 2016 01:38:16 -0500 From: Bart Van Assche To: "Michael S. Tsirkin" CC: "linux-kernel@vger.kernel.org" , "Linus Torvalds" , Christoph Hellwig , Jason Wang , "linux-kbuild@vger.kernel.org" , Michal Marek , Arnd Bergmann , Greg Kroah-Hartman , Matt Mackall , Herbert Xu , David Airlie , Gerd Hoffmann , Ohad Ben-Cohen , Christian Borntraeger , Cornelia Huck , "James E.J. Bottomley" , "David S. Miller" , Jens Axboe , Neil Armstrong , Stefan Hajnoczi , Asias He , "linux-crypto@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "virtualization@lists.linux-foundation.org" , "netdev@vger.kernel.org" , "linux-remoteproc@vger.kernel.org" , "linux-s390@vger.kernel.org" , "kvm@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "v9fs-developer@lists.sourceforge.net" Subject: Re: [PATCH] linux/types.h: enable endian checks for all sparse builds Thread-Topic: [PATCH] linux/types.h: enable endian checks for all sparse builds Thread-Index: AQHSURL2jA2A7bS1DkWDvmuec7SNmA== Date: Thu, 8 Dec 2016 06:38:11 +0000 Message-ID: References: <1481164052-28036-1-git-send-email-mst@redhat.com> <20161208075152-mutt-send-email-mst@kernel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@sandisk.com; x-originating-ip: [24.7.116.167] x-ms-office365-filtering-correlation-id: be93670c-514c-4fde-47a3-08d41f34c7fc x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BLUPR02MB1681; x-microsoft-exchange-diagnostics: 1;BLUPR02MB1681;7:8NMpwOKQUp9nXzkYnroBOZiHjg9Ni3iPUbaqvsfkFpOPCQarBL3q9KE5JYaKiVvW8C0wkU3z05VBe9NAKUvA/JvWPxOIJFGbYilAdb5yFBUCxnrrG0qyN9X1Xu38B7kJgoa3dRgYt6jwSuvTlwNoLJ9aCW1r0tomX2hZtPmPFGdlKJ/JCNHdmCdcizaoMGJfLloqWUxQn9q7zoVQkqxhRtpqIGnn3rCvVtLdPiHljmAqjmjRkqDH9+vUc6HBhqdl+vXLD+rdTBmAHNOlQnaTvbxOG2oTg2o3pB+hk31TaEAL2hfQZQxIw5+zs9d67Vv34lT++n81tUMJRWrmXEjXpkjaCeFemFV/OFyWNQ57C3v5NS0pmeAE3hDG5WKXEIeC9tgN16I4CHB0mtUSXBQIRjxjA1blXuBKwlqByufbGYbckTDlqJ5g7MhYPnZYk0YU8bFUcomA6hDv1x5QXeB+vg==;20:mjhBvu3ct/Wxfw8l9SHgVXol7v4kRBQD9kYQHTFvqu5nTurEJnHlcuyyjFnmlTBsn+qgQwoQDbVlKDLchSghmP3u4pjGS9z+iAKNdBicGdnEIERwFBafhoT9zCZbrj8bcVCT1ConE51arx9Z5fYFfrjuG5JVKXQubYmjsoWtMBgtWfIu4rM5uZWdS2RzzB4Tls6pGSLWitUyPw/978vRJU9491Ro418JxwJg2xEo24Wg276UTFtePlFeLmQwjMgw x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6041248)(20161123560025)(20161123562025)(20161123564025)(20161123555025)(6072148);SRVR:BLUPR02MB1681;BCL:0;PCL:0;RULEID:;SRVR:BLUPR02MB1681; x-forefront-prvs: 0150F3F97D x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(39410400002)(39450400003)(39860400002)(39840400002)(39850400002)(199003)(52544003)(189002)(24454002)(7696004)(101416001)(54356999)(76176999)(50986999)(5660300001)(97736004)(33656002)(229853002)(66066001)(106116001)(7416002)(92566002)(2900100001)(3280700002)(7406005)(3660700001)(122556002)(106356001)(3846002)(102836003)(4326007)(6506006)(189998001)(81156014)(6116002)(77096006)(99286002)(38730400001)(7846002)(76576001)(8676002)(6916009)(9686002)(7736002)(68736007)(74316002)(105586002)(2906002)(81166006)(86362001)(8936002)(305945005)(110136003);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR02MB1681;H:BLUPR02MB1683.namprd02.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Dec 2016 06:38:11.7580 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR02MB1681 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uB86cOgC024872 Content-Length: 1010 Lines: 24 On 12/07/16 21:54, Michael S. Tsirkin wrote: > On Thu, Dec 08, 2016 at 05:21:47AM +0000, Bart Van Assche wrote: >> Additionally, there are notable exceptions to the rule that most drivers >> are endian-clean, e.g. drivers/scsi/qla2xxx. I would appreciate it if it >> would remain possible to check such drivers with sparse without enabling >> endianness checks. Have you considered to change #ifdef __CHECK_ENDIAN__ >> into e.g. #ifndef __DONT_CHECK_ENDIAN__? > > The right thing is probably just to fix these, isn't it? > Until then, why not just ignore the warnings? Neither option is realistic. With endian-checking enabled the qla2xxx driver triggers so many warnings that it becomes a real challenge to filter the non-endian warnings out manually: $ for f in "" CF=-D__CHECK_ENDIAN__; do make M=drivers/scsi/qla2xxx C=2\ $f | &grep -c ': warning:'; done 4 752 If you think it would be easy to fix the endian warnings triggered by the qla2xxx driver, you are welcome to try to fix these. Bart.