Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932687AbcLHG6L (ORCPT ); Thu, 8 Dec 2016 01:58:11 -0500 Received: from mx2.suse.de ([195.135.220.15]:53881 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932547AbcLHG6K (ORCPT ); Thu, 8 Dec 2016 01:58:10 -0500 Subject: Re: [PATCH 1/1 v2] xen: xenbus: set error code on failure To: Pan Bian , David Vrabel , Boris Ostrovsky , xen-devel@lists.xenproject.org References: <1480926142-19882-1-git-send-email-bianpan2016@163.com> Cc: linux-kernel@vger.kernel.org From: Juergen Gross Message-ID: Date: Thu, 8 Dec 2016 07:58:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1480926142-19882-1-git-send-email-bianpan2016@163.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 385 Lines: 13 On 05/12/16 09:22, Pan Bian wrote: > Variable err is initialized with 0. As a result, the return value may > be 0 even if get_zeroed_page() fails to allocate memory. This patch fixes > the bug, initializing err with "-ENOMEM". > > v1 is reviewed by: Juergen Gross > > Signed-off-by: Pan Bian Commited to xen/tip.git for-linus-4.10 Juergen