Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752635AbcLHJMd (ORCPT ); Thu, 8 Dec 2016 04:12:33 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:10823 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752017AbcLHJMa (ORCPT ); Thu, 8 Dec 2016 04:12:30 -0500 Subject: Re: [PATCH v3 4/6] net: stmmac: dwmac1000: fix define DMA_BUS_MODE_RPBL_MASK To: Niklas Cassel , Giuseppe Cavallaro References: <1481120409-18103-1-git-send-email-niklass@axis.com> <1481120409-18103-5-git-send-email-niklass@axis.com> CC: Niklas Cassel , , From: Alexandre Torgue Message-ID: <7fe29358-1c2b-d4b9-88fd-96135262e5d3@st.com> Date: Thu, 8 Dec 2016 10:12:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1481120409-18103-5-git-send-email-niklass@axis.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.48.0.2] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-08_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1116 Lines: 33 Hi Niklas On 12/07/2016 03:20 PM, Niklas Cassel wrote: > From: Niklas Cassel > > DMA_BUS_MODE_RPBL_MASK is really 6 bits, > just like DMA_BUS_MODE_PBL_MASK. > > Signed-off-by: Niklas Cassel > --- > drivers/net/ethernet/stmicro/stmmac/dwmac1000.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac1000.h b/drivers/net/ethernet/stmicro/stmmac/dwmac1000.h > index ff3e5ab39bd0..52b9407a8a39 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac1000.h > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac1000.h > @@ -225,7 +225,7 @@ enum rx_tx_priority_ratio { > > #define DMA_BUS_MODE_FB 0x00010000 /* Fixed burst */ > #define DMA_BUS_MODE_MB 0x04000000 /* Mixed burst */ > -#define DMA_BUS_MODE_RPBL_MASK 0x003e0000 /* Rx-Programmable Burst Len */ > +#define DMA_BUS_MODE_RPBL_MASK 0x007e0000 /* Rx-Programmable Burst Len */ Well spot. You can add my Acked-by. Regards Alex > #define DMA_BUS_MODE_RPBL_SHIFT 17 > #define DMA_BUS_MODE_USP 0x00800000 > #define DMA_BUS_MODE_MAXPBL 0x01000000 >