Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752987AbcLHKJj (ORCPT ); Thu, 8 Dec 2016 05:09:39 -0500 Received: from mga05.intel.com ([192.55.52.43]:59680 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751130AbcLHKJh (ORCPT ); Thu, 8 Dec 2016 05:09:37 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,318,1477983600"; d="scan'208";a="200371503" Date: Thu, 8 Dec 2016 15:49:25 +0530 From: Vinod Koul To: Kirtika Ruchandani Cc: tiwai@suse.com, arnd@arndb.de, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Jeeja KP , "Subhransu S . Prusty" , Mark Brown Subject: Re: [PATCH] ASoC: Intel: Skylake: remove unused 'runtime' variable Message-ID: <20161208101925.GA6408@localhost> References: <1481178380-139648-1-git-send-email-kirtika@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1481178380-139648-1-git-send-email-kirtika@chromium.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 697 Lines: 17 On Wed, Dec 07, 2016 at 10:26:20PM -0800, Kirtika Ruchandani wrote: > skl_platform_open() defines and sets 'struct snd_pcm_runtime* runtime' > but does not use it. Compiling with W=1 gives the following warning, > fix it. > > sound/soc/intel/skylake/skl-pcm.c: In function ‘skl_platform_open’: > sound/soc/intel/skylake/skl-pcm.c:941:26: warning: variable ‘runtime’ set but not used [-Wunused-but-set-variable] > > This was introduced with the initial driver commit a40e693c7f5e > ("ASoC: Intel: Add Skylake HDA platform driver"). > This is a harmless warning and is only being fixed to reduce the noise > with W=1 in the kernel. Acked-by: Vinod Koul -- ~Vinod