Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753468AbcLHO46 (ORCPT ); Thu, 8 Dec 2016 09:56:58 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:43775 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932297AbcLHO44 (ORCPT ); Thu, 8 Dec 2016 09:56:56 -0500 Subject: Re: [PATCH v2] xen/scsifront: don't request a slot on the ring until request is ready To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org References: <20161125202650.GK6266@mwanda> <20161202061545.14614-1-jgross@suse.com> Cc: lambert.quentin@gmail.com, linux-scsi@vger.kernel.org, dan.carpenter@oracle.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com From: Boris Ostrovsky Message-ID: Date: Thu, 8 Dec 2016 09:56:44 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20161202061545.14614-1-jgross@suse.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 546 Lines: 15 On 12/02/2016 01:15 AM, Juergen Gross wrote: > Instead of requesting a new slot on the ring to the backend early, do > so only after all has been setup for the request to be sent. This > makes error handling easier as we don't need to undo the request id > allocation and ring slot allocation. > > Suggested-by: Jan Beulich > Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky (although it would be good to have someone familiar with this code look at this as well).