Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754091AbcLHPlu (ORCPT ); Thu, 8 Dec 2016 10:41:50 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:46841 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754080AbcLHPll (ORCPT ); Thu, 8 Dec 2016 10:41:41 -0500 Date: Thu, 8 Dec 2016 16:31:09 +0100 From: Boris Brezillon To: Cyrille Pitchen Cc: , , , , Subject: Re: [PATCH 1/1] mtd: spi-nor: remove WARN_ONCE() message in spi_nor_write() Message-ID: <20161208163109.17429627@bbrezillon> In-Reply-To: <0078578d0f5d2402ac623afabf601d25998f84a9.1481044434.git.cyrille.pitchen@atmel.com> References: <0078578d0f5d2402ac623afabf601d25998f84a9.1481044434.git.cyrille.pitchen@atmel.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1477 Lines: 35 On Tue, 6 Dec 2016 18:14:24 +0100 Cyrille Pitchen wrote: > This patch removes the WARN_ONCE() test in spi_nor_write(). > This macro triggers the display of a warning message almost every time we > use a UBI file-system because a write operation is performed at offset 64, > which is in the middle of the SPI NOR memory page. This is a valid > operation for ubifs. > > Hence this warning is pretty annoying and useless so we just remove it. > > Signed-off-by: Cyrille Pitchen > Suggested-by: Richard Weinberger > Suggested-by: Andras Szemzo Acked-by: Boris Brezillon > --- > drivers/mtd/spi-nor/spi-nor.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index c9bcd05ca5d9..cdeb2c6b1492 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -1265,9 +1265,6 @@ static int spi_nor_write(struct mtd_info *mtd, loff_t to, size_t len, > ssize_t written; > > page_offset = (to + i) & (nor->page_size - 1); > - WARN_ONCE(page_offset, > - "Writing at offset %zu into a NOR page. Writing partial pages may decrease reliability and increase wear of NOR flash.", > - page_offset); > /* the size of data remaining on the first page */ > page_remain = min_t(size_t, > nor->page_size - page_offset, len - i);