Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933060AbcLHWz6 (ORCPT ); Thu, 8 Dec 2016 17:55:58 -0500 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:46554 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932578AbcLHWz5 (ORCPT ); Thu, 8 Dec 2016 17:55:57 -0500 Date: Fri, 9 Dec 2016 09:55:58 +1100 (AEDT) From: Finn Thain To: Geert Uytterhoeven cc: Greg Ungerer , Sam Creasey , Joshua Thompson , linux-m68k , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 01/22] m68k/atari: Modernize printing of kernel messages In-Reply-To: Message-ID: References: <1481123360-10978-1-git-send-email-geert@linux-m68k.org> <1481123360-10978-2-git-send-email-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2061 Lines: 44 On Thu, 8 Dec 2016, Geert Uytterhoeven wrote: > On Wed, Dec 7, 2016 at 11:36 PM, Finn Thain wrote: > > On Wed, 7 Dec 2016, Geert Uytterhoeven wrote: > >> - Convert from printk() to pr_*(), > >> - Add missing continuations, to fix user-visible breakage, > >> - Drop useless WARNING prefix, > >> - Move trailing spaces to start of continuations. > >> > >> Fixes: 4bcc595ccd80decb ("printk: reinstate KERN_CONT for printing continuation lines") > >> Signed-off-by: Geert Uytterhoeven > >> --- > >> arch/m68k/atari/atakeyb.c | 14 ++++++------ > >> arch/m68k/atari/config.c | 56 +++++++++++++++++++++++------------------------ > >> 2 files changed, 35 insertions(+), 35 deletions(-) > >> > >> diff --git a/arch/m68k/atari/atakeyb.c b/arch/m68k/atari/atakeyb.c > >> index 264db11268039329..37091898adb3d3b5 100644 > >> --- a/arch/m68k/atari/atakeyb.c > >> +++ b/arch/m68k/atari/atakeyb.c > >> @@ -149,7 +149,7 @@ static irqreturn_t atari_keyboard_interrupt(int irq, void *dummy) > >> if (acia_stat & ACIA_OVRN) { > >> /* a very fast typist or a slow system, give a warning */ > >> /* ...happens often if interrupts were disabled for too long */ > >> - printk(KERN_DEBUG "Keyboard overrun\n"); > >> + pr_debug("Keyboard overrun\n"); > >> scancode = acia.key_data; > >> if (ikbd_self_test) > >> /* During self test, don't do resyncing, just process the code */ > > > > This is not equivalent (unless there is a DEBUG macro definition hinding > > in a header file somewhere). Since the changelog doesn't mention > > suppressing any output, perhaps you were deceived by the questionable API, > > as I have been in the past (see 16b9d870a0 and d61c5427f6). > > This is an actual message people want to see in the kernel log, even > when not debugging? > That's really a question for Atari users, of course. For my part, I think you should mention the behavioural change in the commit log. --