Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932795AbcLHXKN (ORCPT ); Thu, 8 Dec 2016 18:10:13 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:33242 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932328AbcLHXKL (ORCPT ); Thu, 8 Dec 2016 18:10:11 -0500 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 925C06025D Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Thu, 8 Dec 2016 15:10:10 -0800 From: "sboyd@codeaurora.org" To: "Y.T. Tang" Cc: Scott Wood , "mturquette@baylibre.com" , "linux-clk@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3] clk: qoriq: added ls1012a clock configuration Message-ID: <20161208231010.GV5423@codeaurora.org> References: <1479955015-37514-1-git-send-email-yuantian.tang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1565 Lines: 42 On 11/25, Y.T. Tang wrote: > Hi Scott, > > > -----Original Message----- > > From: Scott Wood > > Sent: Thursday, November 24, 2016 4:21 PM > > To: Y.T. Tang ; mturquette@baylibre.com > > Cc: sboyd@codeaurora.org; linux-clk@vger.kernel.org; linux- > > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org > > Subject: Re: [PATCH v3] clk: qoriq: added ls1012a clock configuration > > > > On 11/23/2016 08:50 PM, yuantian.tang@nxp.com wrote: > > > From: Tang Yuantian > > > > > > Signed-off-by: Tang Yuantian > > > --- > > > v3: > > > - rebased to latest kernel and re-sorted the code > > [snip] > > > @@ -1316,6 +1334,7 @@ CLK_OF_DECLARE(qoriq_clockgen_2, > > > "fsl,qoriq-clockgen-2.0", clockgen_init); > > > CLK_OF_DECLARE(qoriq_clockgen_ls1021a, "fsl,ls1021a-clockgen", > > > clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_ls1043a, > > > "fsl,ls1043a-clockgen", clockgen_init); > > > CLK_OF_DECLARE(qoriq_clockgen_ls1046a, "fsl,ls1046a-clockgen", > > > clockgen_init); > > > +CLK_OF_DECLARE(qoriq_clockgen_ls1012a, "fsl,ls1012a-clockgen", > > > +clockgen_init); > > > CLK_OF_DECLARE(qoriq_clockgen_ls2080a, "fsl,ls2080a-clockgen", > > > clockgen_init); > > > > You need a better sorting algorithm. :-P > > > I don't think so. This time, each code snip goes right after ls1046a. > The sorting 'algorithm' is best ever. :) > I will sort it and apply it? Ack Scott? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project