Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932648AbcLHXgE (ORCPT ); Thu, 8 Dec 2016 18:36:04 -0500 Received: from mail-db5eur01on0077.outbound.protection.outlook.com ([104.47.2.77]:36405 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932196AbcLHXgC (ORCPT ); Thu, 8 Dec 2016 18:36:02 -0500 From: Scott Wood To: "sboyd@codeaurora.org" , "Y.T. Tang" CC: "mturquette@baylibre.com" , "linux-clk@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3] clk: qoriq: added ls1012a clock configuration Thread-Topic: [PATCH v3] clk: qoriq: added ls1012a clock configuration Thread-Index: AQHSRf17cbDwSU/qekWlkD3LJR5oSQ== Date: Thu, 8 Dec 2016 23:19:12 +0000 Message-ID: References: <1479955015-37514-1-git-send-email-yuantian.tang@nxp.com> <20161208231010.GV5423@codeaurora.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=scott.wood@nxp.com; x-originating-ip: [2601:449:8400:923b:12bf:48ff:fe84:c9a0] x-microsoft-exchange-diagnostics: 1;HE1PR0402MB2843;7:2a1EuB/hEi7PLyka0f3Zz2z/Ss1CgWqYlwzBkulWuQZeet+LmzMHUYCRiATKwvGi0iEstyLIXyLqYaR4BGwpPVpWzx42grI5M+UHUexVqw6fuLbaaO+CXjQu7u3CUvIKMY/wJ9aZQvqNwBYiwhLMUauzvQIUsoshEPDVWDjZmgHz4yOOxKELhCqPD6q7SSmIByXF4Cij/7e2K9c9r1uOMAWBSgyvXPilBFv1J+CkGlmVsEfhP054L1p7pHPv2EdEppMh2Vr/4P2FcnLgn2q9tLicSJGY7ADS4EEKTWvamytlvtebcAhH3F4sLfDp2MieN1otfku4JCpMwU+9EOWz6ICD9mD6ogNzZMG76ylzrQhMgpdA9ktXYoEyIkFayw3r2o/EGcX+IEyZoVTAB3dNItPLFd3qS/TY5hZJ6OxYac4QAb+WjeZVgJJGIRFHYo10Q40gPWxasQAk+Ro0XX3Fhg== x-forefront-antispam-report: SFV:SKI;SCL:-1SFV:NSPM;SFS:(10009020)(6009001)(7916002)(39840400002)(39410400002)(39850400002)(39860400002)(39450400003)(189002)(24454002)(13464003)(199003)(377454003)(106356001)(38730400001)(229853002)(6506006)(105586002)(33656002)(106116001)(76576001)(77096006)(97736004)(6436002)(189998001)(3280700002)(2501003)(2906002)(5001770100001)(122556002)(4326007)(3900700001)(3660700001)(8676002)(8936002)(68736007)(81156014)(9686002)(102836003)(6116002)(7696004)(5660300001)(81166006)(6636002)(2900100001)(92566002)(86362001)(7736002)(93886004)(50986999)(305945005)(74316002)(101416001)(54356999)(76176999);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR0402MB2843;H:DB5PR0401MB1928.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-ms-office365-filtering-correlation-id: 04168cd0-a773-4c20-3a29-08d41fc09eb7 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:HE1PR0402MB2843; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(185117386973197)(258649278758335); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6041248)(20161123564025)(20161123558021)(20161123560025)(20161123562025)(20161123555025)(6072148)(6047074);SRVR:HE1PR0402MB2843;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0402MB2843; x-forefront-prvs: 0150F3F97D spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Dec 2016 23:19:12.0860 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB2843 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uB8Na9Ab023102 Content-Length: 1546 Lines: 45 On 12/08/2016 05:10 PM, sboyd@codeaurora.org wrote: > On 11/25, Y.T. Tang wrote: >> Hi Scott, >> >>> -----Original Message----- >>> From: Scott Wood >>> Sent: Thursday, November 24, 2016 4:21 PM >>> To: Y.T. Tang ; mturquette@baylibre.com >>> Cc: sboyd@codeaurora.org; linux-clk@vger.kernel.org; linux- >>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org >>> Subject: Re: [PATCH v3] clk: qoriq: added ls1012a clock configuration >>> >>> On 11/23/2016 08:50 PM, yuantian.tang@nxp.com wrote: >>>> From: Tang Yuantian >>>> >>>> Signed-off-by: Tang Yuantian >>>> --- >>>> v3: >>>> - rebased to latest kernel and re-sorted the code >>> [snip] >>>> @@ -1316,6 +1334,7 @@ CLK_OF_DECLARE(qoriq_clockgen_2, >>>> "fsl,qoriq-clockgen-2.0", clockgen_init); >>>> CLK_OF_DECLARE(qoriq_clockgen_ls1021a, "fsl,ls1021a-clockgen", >>>> clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_ls1043a, >>>> "fsl,ls1043a-clockgen", clockgen_init); >>>> CLK_OF_DECLARE(qoriq_clockgen_ls1046a, "fsl,ls1046a-clockgen", >>>> clockgen_init); >>>> +CLK_OF_DECLARE(qoriq_clockgen_ls1012a, "fsl,ls1012a-clockgen", >>>> +clockgen_init); >>>> CLK_OF_DECLARE(qoriq_clockgen_ls2080a, "fsl,ls2080a-clockgen", >>>> clockgen_init); >>> >>> You need a better sorting algorithm. :-P >>> >> I don't think so. This time, each code snip goes right after ls1046a. >> The sorting 'algorithm' is best ever. :) >> > > I will sort it and apply it? Ack Scott? > Acked-by: Scott Wood -Scott