Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933051AbcLIA0j (ORCPT ); Thu, 8 Dec 2016 19:26:39 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:54942 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932196AbcLIA0h (ORCPT ); Thu, 8 Dec 2016 19:26:37 -0500 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 10278612CA Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Thu, 8 Dec 2016 16:26:35 -0800 From: Stephen Boyd To: Kuninori Morimoto Cc: Russell King - ARM Linux , Rob Herring , Linux-ALSA , Linux-DT , Michael Turquette , Linux-Kernel , Mark Brown , linux-clk@vger.kernel.org, Linux-ARM Subject: Re: [PATCH 3/3] ASoC: simple-card-utils: enable clocks/clock-names/clock-ranges Message-ID: <20161209002635.GD5423@codeaurora.org> References: <874m2jvtmw.wl%kuninori.morimoto.gx@renesas.com> <87zikbuezr.wl%kuninori.morimoto.gx@renesas.com> <20161208220901.GN5423@codeaurora.org> <874m2eymu3.wl%kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <874m2eymu3.wl%kuninori.morimoto.gx@renesas.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1606 Lines: 55 On 12/09, Kuninori Morimoto wrote: > > Hi Stephen > > > > From: Kuninori Morimoto > > > > > > Current simple-card is supporting this style for clocks > > > > > > sound { > > > ... > > > simple-audio-card,cpu { > > > sound-dai = <&xxx>; > > > clocks = <&cpu_clock>; > > > }; > > > simple-audio-card,codec { > > > sound-dai = <&xxx>; > > > clocks = <&codec_clock>; > > > }; > > > }; > > > > > > Now, it can support this style too, because we can use > > > devm_get_clk_from_child() now. > > > > > > sound { > > > ... > > > clocks = <&cpu_clock>, <&codec_clock>; > > > clock-names = "cpu", "codec"; > > > clock-ranges; > > > ... > > > simple-audio-card,cpu { > > > sound-dai = <&xxx>; > > > }; > > > simple-audio-card,codec { > > > sound-dai = <&xxx>; > > > }; > > > }; > > > > > > Signed-off-by: Kuninori Morimoto > > > > I don't see any reason why we need this patch though. The binding > > works as is, so supporting different styles doesn't seem like a > > good idea to me. Let's just keep what we have? Even if a sub-node > > like cpu or codec gets more than one element in the clocks list > > property, we can make that work by passing a clock-name then > > based on some sort of other knowledge. > > OK, thanks. Let's skip this patch. > But I believe this idea/method itself is not wrong (?) > Right it's not wrong, just seems confusing to have two methods. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project