Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933022AbcLIAbx (ORCPT ); Thu, 8 Dec 2016 19:31:53 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:58880 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753870AbcLIAbv (ORCPT ); Thu, 8 Dec 2016 19:31:51 -0500 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 295B9613B9 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Thu, 8 Dec 2016 16:31:49 -0800 From: "sboyd@codeaurora.org" To: Scott Wood Cc: "Y.T. Tang" , "mturquette@baylibre.com" , "linux-clk@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3] clk: qoriq: added ls1012a clock configuration Message-ID: <20161209003149.GF5423@codeaurora.org> References: <1479955015-37514-1-git-send-email-yuantian.tang@nxp.com> <20161208231010.GV5423@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3592 Lines: 106 On 12/08, Scott Wood wrote: > On 12/08/2016 05:10 PM, sboyd@codeaurora.org wrote: > > On 11/25, Y.T. Tang wrote: > >> Hi Scott, > >> > >>> -----Original Message----- > >>> From: Scott Wood > >>> Sent: Thursday, November 24, 2016 4:21 PM > >>> To: Y.T. Tang ; mturquette@baylibre.com > >>> Cc: sboyd@codeaurora.org; linux-clk@vger.kernel.org; linux- > >>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org > >>> Subject: Re: [PATCH v3] clk: qoriq: added ls1012a clock configuration > >>> > >>> On 11/23/2016 08:50 PM, yuantian.tang@nxp.com wrote: > >>>> From: Tang Yuantian > >>>> > >>>> Signed-off-by: Tang Yuantian > >>>> --- > >>>> v3: > >>>> - rebased to latest kernel and re-sorted the code > >>> [snip] > >>>> @@ -1316,6 +1334,7 @@ CLK_OF_DECLARE(qoriq_clockgen_2, > >>>> "fsl,qoriq-clockgen-2.0", clockgen_init); > >>>> CLK_OF_DECLARE(qoriq_clockgen_ls1021a, "fsl,ls1021a-clockgen", > >>>> clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_ls1043a, > >>>> "fsl,ls1043a-clockgen", clockgen_init); > >>>> CLK_OF_DECLARE(qoriq_clockgen_ls1046a, "fsl,ls1046a-clockgen", > >>>> clockgen_init); > >>>> +CLK_OF_DECLARE(qoriq_clockgen_ls1012a, "fsl,ls1012a-clockgen", > >>>> +clockgen_init); > >>>> CLK_OF_DECLARE(qoriq_clockgen_ls2080a, "fsl,ls2080a-clockgen", > >>>> clockgen_init); > >>> > >>> You need a better sorting algorithm. :-P > >>> > >> I don't think so. This time, each code snip goes right after ls1046a. > >> The sorting 'algorithm' is best ever. :) > >> > > > > I will sort it and apply it? Ack Scott? > > > > Acked-by: Scott Wood > Thanks. Applied this to clk-next: ---8<---- From: Tang Yuantian Subject: [PATCH] clk: qoriq: added ls1012a clock configuration Acked-by: Scott Wood Signed-off-by: Tang Yuantian [sboyd@codeaurora.org: Sorted list] Signed-off-by: Stephen Boyd --- drivers/clk/clk-qoriq.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c index 7dd4351efdd6..d0bf8b1c67de 100644 --- a/drivers/clk/clk-qoriq.c +++ b/drivers/clk/clk-qoriq.c @@ -291,6 +291,14 @@ static const struct clockgen_muxinfo ls1046a_hwa2 = { }, }; +static const struct clockgen_muxinfo ls1012a_cmux = { + { + [0] = { CLKSEL_VALID, CGA_PLL1, PLL_DIV1 }, + {}, + [2] = { CLKSEL_VALID, CGA_PLL1, PLL_DIV2 }, + } +}; + static const struct clockgen_muxinfo t1023_hwa1 = { { {}, @@ -529,6 +537,16 @@ static const struct clockgen_chipinfo chipinfo[] = { .flags = CG_PLL_8BIT, }, { + .compat = "fsl,ls1012a-clockgen", + .cmux_groups = { + &ls1012a_cmux + }, + .cmux_to_group = { + 0, -1 + }, + .pll_mask = 0x03, + }, + { .compat = "fsl,ls2080a-clockgen", .cmux_groups = { &clockgen2_cmux_cga12, &clockgen2_cmux_cgb @@ -1313,6 +1331,7 @@ static void __init clockgen_init(struct device_node *np) CLK_OF_DECLARE(qoriq_clockgen_1, "fsl,qoriq-clockgen-1.0", clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_2, "fsl,qoriq-clockgen-2.0", clockgen_init); +CLK_OF_DECLARE(qoriq_clockgen_ls1012a, "fsl,ls1012a-clockgen", clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_ls1021a, "fsl,ls1021a-clockgen", clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_ls1043a, "fsl,ls1043a-clockgen", clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_ls1046a, "fsl,ls1046a-clockgen", clockgen_init); -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project