Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932307AbcLICxp (ORCPT ); Thu, 8 Dec 2016 21:53:45 -0500 Received: from out01.mta.xmission.com ([166.70.13.231]:59656 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752356AbcLICxn (ORCPT ); Thu, 8 Dec 2016 21:53:43 -0500 From: ebiederm@xmission.com (Eric W. Biederman) To: Nikolay Borisov Cc: Nikolay Borisov , containers@lists.linux-foundation.org, jack@suse.cz, linux-kernel@vger.kernel.org, serge@hallyn.com References: <20161010164046.GG24081@quack2.suse.cz> <1476171382-11911-1-git-send-email-kernel@kyup.com> <674564a4-ff05-b4d6-4a98-8cfc2e609325@kyup.com> <87twafci52.fsf@xmission.com> Date: Fri, 09 Dec 2016 15:50:38 +1300 In-Reply-To: (Nikolay Borisov's message of "Thu, 8 Dec 2016 08:58:31 +0200") Message-ID: <87y3zpdddt.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1cFBJY-0008IN-2C;;;mid=<87y3zpdddt.fsf@xmission.com>;;;hst=in02.mta.xmission.com;;;ip=101.100.131.98;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1+6H0glyuJBbSQyYgXQXsifOLD0x+74LKk= X-SA-Exim-Connect-IP: 101.100.131.98 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.7 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.4996] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa07 1397; Body=1 Fuz1=1 Fuz2=1] X-Spam-DCC: XMission; sa07 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;Nikolay Borisov X-Spam-Relay-Country: X-Spam-Timing: total 5304 ms - load_scoreonly_sql: 0.04 (0.0%), signal_user_changed: 3.8 (0.1%), b_tie_ro: 2.6 (0.0%), parse: 1.06 (0.0%), extract_message_metadata: 13 (0.2%), get_uri_detail_list: 1.78 (0.0%), tests_pri_-1000: 4.3 (0.1%), tests_pri_-950: 1.17 (0.0%), tests_pri_-900: 0.98 (0.0%), tests_pri_-400: 20 (0.4%), check_bayes: 19 (0.4%), b_tokenize: 5 (0.1%), b_tok_get_all: 6 (0.1%), b_comp_prob: 1.94 (0.0%), b_tok_touch_all: 2.9 (0.1%), b_finish: 0.68 (0.0%), tests_pri_0: 308 (5.8%), check_dkim_signature: 0.65 (0.0%), check_dkim_adsp: 3.4 (0.1%), tests_pri_500: 4949 (93.3%), poll_dns_idle: 4943 (93.2%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH v2] inotify: Convert to using per-namespace limits X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1507 Lines: 37 Nikolay Borisov writes: > On 8.12.2016 03:40, Eric W. Biederman wrote: >> Nikolay Borisov writes: >> >>> Gentle ping, now that rc1 has shipped and Jan's sysctl concern hopefully >>> resolved. >> >> After getting slowed down by some fixes I am now taking a hard look at >> your patch in the hopes of merging it. >> >> Did you happen to see the kbuild test roboot boot failures and did you >> happen to look into what caused them? I have just skimmed them and it >> appears to be related to your patch. > > I saw them in the beginning but they did look like a generic memory > corruption and I believe at the time those patches were submitted there > was a lingering memory corruption hitting various patches. Thus I didn't > think it was related to my patches. I've since left my work so been > taking a bit of time off and haven't looked really hard, so those > patches have been kind of lingering. Fair enough. I generally give the kbuild folks the benefit of the doubt as they try hard to avoid false positives. > But now that you mention it I will try and take a second look to see > what might cause the memory corruption? Is there a way to force 0day to > re-run them to see whether the failure was indeed caused by my patches > or were intermittent? Good question. I will push the patch to my for-testing branch and see if any problems show up. That plus I will read through your patch and make certain I can understand what is going on. Eric