Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932688AbcLII6A (ORCPT ); Fri, 9 Dec 2016 03:58:00 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33385 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752672AbcLII56 (ORCPT ); Fri, 9 Dec 2016 03:57:58 -0500 Date: Fri, 9 Dec 2016 09:57:52 +0100 From: Richard Cochran To: Harini Katakam Cc: Andrei Pistirica , netdev@vger.kernel.org, "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , David Miller , Nicolas Ferre , Harini Katakam , Punnaiah Choudary Kalluri , "michals@xilinx.com" , Anirudha Sarangi , Boris Brezillon , alexandre.belloni@free-electrons.com, tbultel@pixelsurmer.com, Rafal Ozieblo Subject: Re: [RFC PATCH net-next v3 1/2] macb: Add 1588 support in Cadence GEM. Message-ID: <20161209085752.GB16009@localhost.localdomain> References: <1481134912-2243-1-git-send-email-andrei.pistirica@microchip.com> <20161207193908.GA13062@netboy> <20161207210416.GA27622@netboy> <07C910AB6AC6C345A093D5A08F5AF568CB74AF28@CHN-SV-EXMX03.mchp-main.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 588 Lines: 14 On Fri, Dec 09, 2016 at 11:07:23AM +0530, Harini Katakam wrote: > I'm afraid I don't get why we are choosing the most limited max adj.. > Sorry if I'm missing something - could you please help me understand? This max_adj is only important when the local clock offset is large and user space chooses not to step the time value. In that case, user space will want to run the clock as fast (or as slow) as possible in order to catch up with the remote clock. The driver must provide a max_adj that is always safe for user space to apply via the clock_adjtime() system call. HTH, Richard