Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932884AbcLIKWU (ORCPT ); Fri, 9 Dec 2016 05:22:20 -0500 Received: from mx2.suse.de ([195.135.220.15]:55922 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932468AbcLIKWS (ORCPT ); Fri, 9 Dec 2016 05:22:18 -0500 Date: Fri, 09 Dec 2016 11:22:15 +0100 Message-ID: From: Takashi Iwai To: "Con Kolivas" Cc: , Subject: Re: [PATCH SND/USB]: Add QuickCam Communicate Deluxe/S7500 to volume_control_quirks. In-Reply-To: <2208242.ISe40cRj8e@hex> References: <2208242.ISe40cRj8e@hex> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1471 Lines: 47 On Fri, 09 Dec 2016 05:15:57 +0100, Con Kolivas wrote: > > The Logitech QuickCam Communicate Deluxe/S7500 microphone fails with the > following warning. > > [ 6.778995] usb 2-1.2.2.2: Warning! Unlikely big volume range (=3072), > cval->res is probably wrong. > [ 6.778996] usb 2-1.2.2.2: [5] FU [Mic Capture Volume] ch = 1, val = > 4608/7680/1 > > Adding it to the list of devices in volume_control_quirks makes it work > properly, fixing related typo. > > Signed-off-by: Con Kolivas Applied (with Cc to stable), thanks. Takashi > > --- > sound/usb/mixer.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c > index 2f8c388..4703cae 100644 > --- a/sound/usb/mixer.c > +++ b/sound/usb/mixer.c > @@ -932,9 +932,10 @@ static void volume_control_quirks(struct usb_mixer_elem_info *cval, > case USB_ID(0x046d, 0x0826): /* HD Webcam c525 */ > case USB_ID(0x046d, 0x08ca): /* Logitech Quickcam Fusion */ > case USB_ID(0x046d, 0x0991): > + case USB_ID(0x046d, 0x09a2): /* QuickCam Communicate Deluxe/S7500 */ > /* Most audio usb devices lie about volume resolution. > * Most Logitech webcams have res = 384. > - * Proboly there is some logitech magic behind this number --fishor > + * Probably there is some logitech magic behind this number --fishor > */ > if (!strcmp(kctl->id.name, "Mic Capture Volume")) { > usb_audio_info(chip, > -- > 2.7.4 > > >