Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753971AbcLIL4Q (ORCPT ); Fri, 9 Dec 2016 06:56:16 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:48450 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753632AbcLIL4P (ORCPT ); Fri, 9 Dec 2016 06:56:15 -0500 Date: Fri, 9 Dec 2016 12:53:30 +0100 (CET) From: Thomas Gleixner To: Sebastian Andrzej Siewior cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, Jean Delvare , rt@linuxtronix.de, Guenter Roeck , Sebastian Andrzej Siewior , rt@linutronix.de Subject: Re: [PATCH 06/20] hwmon/via-cputemp: Convert to hotplug state machine In-Reply-To: <20161117183541.8588-7-bigeasy@linutronix.de> Message-ID: References: <20161117183541.8588-1-bigeasy@linutronix.de> <20161117183541.8588-7-bigeasy@linutronix.de> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 901 Lines: 25 Guenter, On Thu, 17 Nov 2016, Sebastian Andrzej Siewior wrote: > Install the callbacks via the state machine and let the core invoke the > callbacks on the already online CPUs. When the hotplug state is > unregistered the cleanup function is called for each cpu. So both cpu loops > in init() and exit() are not longer required. Can we please get those two VIA patches merged for 4.10? They are blocking the final removal of the CPU hotplug notifier crap. The first one which removes that loop is really harmless as there are no multisocket VIAs. Heterogenous cores in a single die would be surprising and the loop check would be the least of our worries in that case. IOW, it would never get so far... The one converting the notifier is not changing any of the functionality. I cannot test on all VIA SMP variants either, but at least on the one I have access to it just works. Thanks, tglx