Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933241AbcLIMJa (ORCPT ); Fri, 9 Dec 2016 07:09:30 -0500 Received: from icp-osb-irony-out7.external.iinet.net.au ([203.59.1.107]:46557 "EHLO icp-osb-irony-out7.external.iinet.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932845AbcLIMJ3 (ORCPT ); Fri, 9 Dec 2016 07:09:29 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2DgAACGnkpY/zSkqnwNURkBAQEBAQEBAQEBAQcBAQEBAYM3AQEBAQGBf6M5AQaBHZJzhBmGIQKCUwECAQEBAQEChXMBAQEDOEEQCw0BCi5XBgEMBgIBAbAFgxEqiwEBAQEBAQEBAQEBAQEBAQEBIoV0gkcIgU6BCIopBYhjkgcBm0+GF44LhA6BVBUOg2AcgW9ghwErghABAQE X-IPAS-Result: A2DgAACGnkpY/zSkqnwNURkBAQEBAQEBAQEBAQcBAQEBAYM3AQEBAQGBf6M5AQaBHZJzhBmGIQKCUwECAQEBAQEChXMBAQEDOEEQCw0BCi5XBgEMBgIBAbAFgxEqiwEBAQEBAQEBAQEBAQEBAQEBIoV0gkcIgU6BCIopBYhjkgcBm0+GF44LhA6BVBUOg2AcgW9ghwErghABAQE X-IronPort-AV: E=Sophos;i="5.33,324,1477929600"; d="scan'208";a="848162420" Subject: Re: [PATCH 06/22] m68k/coldfire: Modernize printing of kernel messages To: Finn Thain , Geert Uytterhoeven References: <1481123360-10978-1-git-send-email-geert@linux-m68k.org> <1481123360-10978-7-git-send-email-geert@linux-m68k.org> Cc: Sam Creasey , Joshua Thompson , linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org From: Greg Ungerer Message-ID: Date: Fri, 9 Dec 2016 22:09:25 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1829 Lines: 51 Hi Finn, Geert, On 08/12/16 08:53, Finn Thain wrote: > > On Wed, 7 Dec 2016, Geert Uytterhoeven wrote: > >> - Introduce helpers for printing debug messages, incl. dummies for >> validating format strings when debugging is disabled, >> - Convert from printk() to pr_*(), >> - Correct printf()-style format specifiers, >> - Drop superfluous casts, >> >> Signed-off-by: Geert Uytterhoeven >> --- >> arch/m68k/coldfire/m528x.c | 4 +- >> arch/m68k/coldfire/sltimers.c | 4 +- >> arch/m68k/coldfire/timers.c | 4 +- >> arch/m68k/coldfire/vectors.c | 2 +- >> arch/m68k/include/asm/dma.h | 98 +++++++++++++------------------------ >> arch/m68k/include/asm/mcf_pgtable.h | 9 ++-- >> 6 files changed, 44 insertions(+), 77 deletions(-) >> [snip] >> diff --git a/arch/m68k/coldfire/vectors.c b/arch/m68k/coldfire/vectors.c >> index 08923fe600e013d9..a185df5963d4ae50 100644 >> --- a/arch/m68k/coldfire/vectors.c >> +++ b/arch/m68k/coldfire/vectors.c >> @@ -24,7 +24,7 @@ >> asmlinkage void dbginterrupt_c(struct frame *fp) >> { >> extern void dump(struct pt_regs *fp); >> - printk(KERN_DEBUG "%s(%d): BUS ERROR TRAP\n", __FILE__, __LINE__); >> + pr_debug("%s(%d): BUS ERROR TRAP\n", __FILE__, __LINE__); >> dump((struct pt_regs *) fp); >> asm("halt"); >> } > > This file also seems to lack #define DEBUG, so you and Greg might want to > check this change. I think we still want this message in, even if DEBUG is not defined. This code is conditionally compiled in for hardware debuger processing - and this message should really come out if this trap case occurs so the user has some idea that it just tripped. (The text of the message is not perfect, but that is a separate issue). Perhaps pr_alert() or pr_crit() would be better? Regards Greg