Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933337AbcLIMKH (ORCPT ); Fri, 9 Dec 2016 07:10:07 -0500 Received: from icp-osb-irony-out7.external.iinet.net.au ([203.59.1.107]:57415 "EHLO icp-osb-irony-out7.external.iinet.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932313AbcLIMKG (ORCPT ); Fri, 9 Dec 2016 07:10:06 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2DfAABfnEpY/zSkqnwNURkBAQEBAQEBAQEBAQcBAQEBAYM3AQEBAQGBbxCkXZJzhBmGIQKCUwECAQEBAQEChXMBAQEDOEEQCw0LLlcGAQwGAgEBsAaDESqLAAEBAQEBAQEBAQEBAQEBAQEBIYg7gl6KKQWaagGbT4YXkhmBVBUOg2AcgW9gAYk7AQEB X-IPAS-Result: A2DfAABfnEpY/zSkqnwNURkBAQEBAQEBAQEBAQcBAQEBAYM3AQEBAQGBbxCkXZJzhBmGIQKCUwECAQEBAQEChXMBAQEDOEEQCw0LLlcGAQwGAgEBsAaDESqLAAEBAQEBAQEBAQEBAQEBAQEBIYg7gl6KKQWaagGbT4YXkhmBVBUOg2AcgW9gAYk7AQEB X-IronPort-AV: E=Sophos;i="5.33,324,1477929600"; d="scan'208";a="848161446" Subject: Re: [PATCH 04/22] m68k/68000: Modernize printing of kernel messages To: Geert Uytterhoeven , Sam Creasey , Joshua Thompson , Finn Thain References: <1481123360-10978-1-git-send-email-geert@linux-m68k.org> <1481123360-10978-5-git-send-email-geert@linux-m68k.org> Cc: linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org From: Greg Ungerer Message-ID: <9e2d5c25-63bc-649d-0e90-4e8734052251@linux-m68k.org> Date: Fri, 9 Dec 2016 22:00:46 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1481123360-10978-5-git-send-email-geert@linux-m68k.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2982 Lines: 85 Hi Geert, On 08/12/16 01:09, Geert Uytterhoeven wrote: > Convert from printk() to pr_*(). > > Signed-off-by: Geert Uytterhoeven Looks good to me, so: Acked-by: Greg Ungerer Regards Greg > --- > arch/m68k/68000/m68328.c | 6 +++--- > arch/m68k/68000/m68EZ328.c | 6 +++--- > arch/m68k/68000/m68VZ328.c | 6 +++--- > 3 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/arch/m68k/68000/m68328.c b/arch/m68k/68000/m68328.c > index e53caf4c3bfbf9d1..419751b15ec8b5f1 100644 > --- a/arch/m68k/68000/m68328.c > +++ b/arch/m68k/68000/m68328.c > @@ -45,9 +45,9 @@ void m68328_reset (void) > > void __init config_BSP(char *command, int len) > { > - printk(KERN_INFO "\n68328 support D. Jeff Dionne \n"); > - printk(KERN_INFO "68328 support Kenneth Albanowski \n"); > - printk(KERN_INFO "68328/Pilot support Bernhard Kuhn \n"); > + pr_info("68328 support D. Jeff Dionne \n"); > + pr_info("68328 support Kenneth Albanowski \n"); > + pr_info("68328/Pilot support Bernhard Kuhn \n"); > > mach_hwclk = m68328_hwclk; > mach_reset = m68328_reset; > diff --git a/arch/m68k/68000/m68EZ328.c b/arch/m68k/68000/m68EZ328.c > index e6ab321f93f832e9..6a309a3cfbfc1953 100644 > --- a/arch/m68k/68000/m68EZ328.c > +++ b/arch/m68k/68000/m68EZ328.c > @@ -57,12 +57,12 @@ void __init config_BSP(char *command, int len) > { > unsigned char *p; > > - printk(KERN_INFO "\n68EZ328 DragonBallEZ support (C) 1999 Rt-Control, Inc\n"); > + pr_info("68EZ328 DragonBallEZ support (C) 1999 Rt-Control, Inc\n"); > > #ifdef CONFIG_UCSIMM > - printk(KERN_INFO "uCsimm serial string [%s]\n",getserialnum()); > + pr_info("uCsimm serial string [%s]\n", getserialnum()); > p = cs8900a_hwaddr = gethwaddr(0); > - printk(KERN_INFO "uCsimm hwaddr %pM\n", p); > + pr_info("uCsimm hwaddr %pM\n", p); > > p = getbenv("APPEND"); > if (p) strcpy(p,command); > diff --git a/arch/m68k/68000/m68VZ328.c b/arch/m68k/68000/m68VZ328.c > index 1154bdb220a022cd..81b5491685a4a2ab 100644 > --- a/arch/m68k/68000/m68VZ328.c > +++ b/arch/m68k/68000/m68VZ328.c > @@ -150,9 +150,9 @@ static void __init init_hardware(char *command, int size) > { > char *p; > > - printk(KERN_INFO "uCdimm serial string [%s]\n", getserialnum()); > + pr_info("uCdimm serial string [%s]\n", getserialnum()); > p = cs8900a_hwaddr = gethwaddr(0); > - printk(KERN_INFO "uCdimm hwaddr %pM\n", p); > + pr_info("uCdimm hwaddr %pM\n", p); > p = getbenv("APPEND"); > if (p) > strcpy(p, command); > @@ -177,7 +177,7 @@ static void __init init_hardware(char *command, int size) > > void __init config_BSP(char *command, int size) > { > - printk(KERN_INFO "68VZ328 DragonBallVZ support (c) 2001 Lineo, Inc.\n"); > + pr_info("68VZ328 DragonBallVZ support (c) 2001 Lineo, Inc.\n"); > > init_hardware(command, size); > >