Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753002AbcLIMrK (ORCPT ); Fri, 9 Dec 2016 07:47:10 -0500 Received: from mx2.suse.de ([195.135.220.15]:47798 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752823AbcLIMrI (ORCPT ); Fri, 9 Dec 2016 07:47:08 -0500 Date: Fri, 9 Dec 2016 13:47:05 +0100 (CET) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Pan Bian cc: Oliver Neukum , Benjamin Tissoires , linux-usb@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1 v2] input: usbhid: fix improper return value In-Reply-To: <1480937844-21513-1-git-send-email-bianpan2016@163.com> Message-ID: References: <1480937844-21513-1-git-send-email-bianpan2016@163.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 309 Lines: 11 On Mon, 5 Dec 2016, Pan Bian wrote: > Function hid_post_reset() should return negative error codes on > failures. However, in its implementation, it incorrectly returns 1. > This patch fixes the bug, returning proper error codes on failures. Applied to for-4.10/upstream. Thanks, -- Jiri Kosina SUSE Labs