Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754088AbcLIPPt (ORCPT ); Fri, 9 Dec 2016 10:15:49 -0500 Received: from smtprelay.synopsys.com ([198.182.60.111]:60378 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753790AbcLIPPs (ORCPT ); Fri, 9 Dec 2016 10:15:48 -0500 Subject: Re: [PATCH net-next 0/2] Initial driver for Synopsys DWC XLGMAC To: Jie Deng , "davem@davemloft.net" , "f.fainelli@gmail.com" , "netdev@vger.kernel.org" References: CC: "linux-kernel@vger.kernel.org" , "lars.persson@axis.com" , "thomas.lendacky@amd.com" From: Carlos Palminha Message-ID: <584ACA9E.8010602@synopsys.com> Date: Fri, 9 Dec 2016 15:15:42 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.107.15.22] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3547 Lines: 70 Hi Jie, I don't think we have the need to create the "dwc" subdirectory under "synopsys". Its preferable to have them directly under drivers/net/ethernet/synopsys. Regards, C.Palminha On 07-12-2016 03:57, Jie Deng wrote: > This series provides the support for 25/40/50/100 GbE > devices using Synopsys DWC Enterprise Ethernet (XLGMAC). > > The first patch adds support for Synopsys XLGMII. > The second patch provides the initial driver for Synopsys XLGMAC > > The driver has three layers by refactoring AMD XGBE. > > dwc-eth-xxx.x > The DWC ethernet core layer (DWC ECL). This layer contains codes > can be shared by different DWC series ethernet cores > > dwc-xxx.x (e.g. dwc-xlgmac.c) > The DWC MAC HW adapter layer (DWC MHAL). This layer contains > special support for a specific MAC. e.g. currently, XLGMAC. > > xxx-xxx-pci.c xxx-xxx-plat.c (e.g. dwc-xlgmac-pci.c) > The glue adapter layer (GAL). Vendors who adopt Synopsys Etherent > cores can develop a glue driver for their platform. > > Jie Deng (2): > net: phy: add extension of phy-mode for XLGMII > net: ethernet: Initial driver for Synopsys DWC XLGMAC > > Documentation/devicetree/bindings/net/ethernet.txt | 1 + > MAINTAINERS | 6 + > drivers/net/ethernet/synopsys/Kconfig | 2 + > drivers/net/ethernet/synopsys/Makefile | 1 + > drivers/net/ethernet/synopsys/dwc/Kconfig | 37 + > drivers/net/ethernet/synopsys/dwc/Makefile | 9 + > drivers/net/ethernet/synopsys/dwc/dwc-eth-dcb.c | 228 ++ > .../net/ethernet/synopsys/dwc/dwc-eth-debugfs.c | 328 +++ > drivers/net/ethernet/synopsys/dwc/dwc-eth-desc.c | 715 +++++ > .../net/ethernet/synopsys/dwc/dwc-eth-ethtool.c | 567 ++++ > drivers/net/ethernet/synopsys/dwc/dwc-eth-hw.c | 3098 ++++++++++++++++++++ > drivers/net/ethernet/synopsys/dwc/dwc-eth-mdio.c | 252 ++ > drivers/net/ethernet/synopsys/dwc/dwc-eth-net.c | 2319 +++++++++++++++ > drivers/net/ethernet/synopsys/dwc/dwc-eth-ptp.c | 216 ++ > drivers/net/ethernet/synopsys/dwc/dwc-eth-regacc.h | 1115 +++++++ > drivers/net/ethernet/synopsys/dwc/dwc-eth.h | 738 +++++ > drivers/net/ethernet/synopsys/dwc/dwc-xlgmac-pci.c | 538 ++++ > drivers/net/ethernet/synopsys/dwc/dwc-xlgmac.c | 135 + > drivers/net/ethernet/synopsys/dwc/dwc-xlgmac.h | 85 + > include/linux/phy.h | 3 + > 20 files changed, 10393 insertions(+) > create mode 100644 drivers/net/ethernet/synopsys/dwc/Kconfig > create mode 100644 drivers/net/ethernet/synopsys/dwc/Makefile > create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-eth-dcb.c > create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-eth-debugfs.c > create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-eth-desc.c > create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-eth-ethtool.c > create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-eth-hw.c > create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-eth-mdio.c > create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-eth-net.c > create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-eth-ptp.c > create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-eth-regacc.h > create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-eth.h > create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-xlgmac-pci.c > create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-xlgmac.c > create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-xlgmac.h >