Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754078AbcLIP1s (ORCPT ); Fri, 9 Dec 2016 10:27:48 -0500 Received: from mail-qk0-f169.google.com ([209.85.220.169]:33941 "EHLO mail-qk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752165AbcLIP1r (ORCPT ); Fri, 9 Dec 2016 10:27:47 -0500 MIME-Version: 1.0 In-Reply-To: <1480600080-30196-1-git-send-email-benjamin.gaignard@linaro.org> References: <1480600080-30196-1-git-send-email-benjamin.gaignard@linaro.org> From: Benjamin Gaignard Date: Fri, 9 Dec 2016 16:27:45 +0100 Message-ID: Subject: Re: [PATCH] nommu: allow mmap when !CONFIG_MMU To: linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, Linux Kernel Mailing List , Robin.Murphy@arm.com Cc: Benjamin Gaignard , Catalin Marinas , Arnd Bergmann , vladimir.murzin@arm.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1226 Lines: 34 + Vladimir 2016-12-01 14:48 GMT+01:00 Benjamin Gaignard : > commit ab6494f0c96f ("nommu: Add noMMU support to the DMA API") have > add CONFIG_MMU compilation flag but that prohibit to use dma_mmap_wc() > when the platform doesn't have MMU. > > This patch call vm_iomap_memory() in noMMU case to test if addresses > are correct and set wma->vm_flags rather than all return an error. > > Signed-off-by: Benjamin Gaignard > Cc: Catalin Marinas > Cc: arnd@arndb.de > --- > arch/arm/mm/dma-mapping.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c > index ab4f745..230875e 100644 > --- a/arch/arm/mm/dma-mapping.c > +++ b/arch/arm/mm/dma-mapping.c > @@ -868,6 +868,9 @@ static int __arm_dma_mmap(struct device *dev, struct vm_area_struct *vma, > vma->vm_end - vma->vm_start, > vma->vm_page_prot); > } > +#else > + ret = vm_iomap_memory(vma, vma->vm_start, > + (vma->vm_end - vma->vm_start)); > #endif /* CONFIG_MMU */ > > return ret; > -- > 1.9.1 >