Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933867AbcLIQFr (ORCPT ); Fri, 9 Dec 2016 11:05:47 -0500 Received: from merlin.infradead.org ([205.233.59.134]:46802 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933626AbcLIQFo (ORCPT ); Fri, 9 Dec 2016 11:05:44 -0500 Date: Fri, 9 Dec 2016 17:05:34 +0100 From: Peter Zijlstra To: Waiman Long Cc: Ingo Molnar , linux-kernel@vger.kernel.org, Pan Xinhui , Boqun Feng , Will Deacon Subject: Re: [PATCH-tip] locking/pvqspinlock: Relax cmpxchg's to improve performance on some archs Message-ID: <20161209160534.GX3124@twins.programming.kicks-ass.net> References: <1481051682-29438-1-git-send-email-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1481051682-29438-1-git-send-email-longman@redhat.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 372 Lines: 8 On Tue, Dec 06, 2016 at 02:14:42PM -0500, Waiman Long wrote: > A number of cmpxchg calls in qspinlock_paravirt.h were replaced by more > relaxed versions to improve performance on architectures that use LL/SC. I would feel so much better if each change were to have some rationale included. Either enumerate them in the changelog, or split them up into smaller patches.