Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753944AbcLIRGz (ORCPT <rfc822;w@1wt.eu>);
        Fri, 9 Dec 2016 12:06:55 -0500
Received: from mx2.suse.de ([195.135.220.15]:59202 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752184AbcLIRGx (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 9 Dec 2016 12:06:53 -0500
Date: Fri, 9 Dec 2016 18:06:44 +0100 (CET)
From: Miroslav Benes <mbenes@suse.cz>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
cc: shuah@kernel.org, jeyu@redhat.com, rusty@rustcorp.com.au,
        ebiederm@xmission.com, dmitry.torokhov@gmail.com, acme@redhat.com,
        corbet@lwn.net, martin.wilck@suse.com, mmarek@suse.com,
        pmladek@suse.com, hare@suse.com, rwright@hpe.com, jeffm@suse.com,
        DSterba@suse.com, fdmanana@suse.com, neilb@suse.com,
        linux@roeck-us.net, rgoldwyn@suse.com, subashab@codeaurora.org,
        xypron.glpk@gmx.de, keescook@chromium.org, atomlin@redhat.com,
        paulmck@linux.vnet.ibm.com, dan.j.williams@intel.com,
        jpoimboe@redhat.com, davem@davemloft.net, mingo@redhat.com,
        akpm@linux-foundation.org, torvalds@linux-foundation.org,
        linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC 02/10] module: fix memory leak on early load_module()
 failures
In-Reply-To: <20161208194802.2438-1-mcgrof@kernel.org>
Message-ID: <alpine.LNX.2.00.1612091803560.26570@pobox.suse.cz>
References: <20161208184801.1689-1-mcgrof@kernel.org> <20161208194802.2438-1-mcgrof@kernel.org>
User-Agent: Alpine 2.00 (LNX 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2259
Lines: 66

On Thu, 8 Dec 2016, Luis R. Rodriguez wrote:

> While looking for early possible module loading failures I was
> able to reproduce a memory leak possible with kmemleak. There
> are a few rare ways to trigger a failure:
> 
>   o we've run into a failure while processing kernel parameters
>     (parse_args() returns an error)
>   o mod_sysfs_setup() fails
>   o we're a live patch module and copy_module_elf() fails
> 
> Chances of running into this issue is really low.
> 
> kmemleak splat:
> 
> unreferenced object 0xffff9f2c4ada1b00 (size 32):
>   comm "kworker/u16:4", pid 82, jiffies 4294897636 (age 681.816s)
>   hex dump (first 32 bytes):
>     6d 65 6d 73 74 69 63 6b 30 00 00 00 00 00 00 00  memstick0.......
>     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
>   backtrace:
>     [<ffffffff8c6cfeba>] kmemleak_alloc+0x4a/0xa0
>     [<ffffffff8c200046>] __kmalloc_track_caller+0x126/0x230
>     [<ffffffff8c1bc581>] kstrdup+0x31/0x60
>     [<ffffffff8c1bc5d4>] kstrdup_const+0x24/0x30
>     [<ffffffff8c3c23aa>] kvasprintf_const+0x7a/0x90
>     [<ffffffff8c3b5481>] kobject_set_name_vargs+0x21/0x90
>     [<ffffffff8c4fbdd7>] dev_set_name+0x47/0x50
>     [<ffffffffc07819e5>] memstick_check+0x95/0x33c [memstick]
>     [<ffffffff8c09c893>] process_one_work+0x1f3/0x4b0
>     [<ffffffff8c09cb98>] worker_thread+0x48/0x4e0
>     [<ffffffff8c0a2b79>] kthread+0xc9/0xe0
>     [<ffffffff8c6dab5f>] ret_from_fork+0x1f/0x40
>     [<ffffffffffffffff>] 0xffffffffffffffff
> 
> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>

Reviewed-by: Miroslav Benes <mbenes@suse.cz>

What about

Fixes: e180a6b7759a ("param: fix charp parameters set via sysfs")

?

Miroslav

> ---
>  kernel/module.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/module.c b/kernel/module.c
> index f7482db0f843..e420ed67e533 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -3722,6 +3722,7 @@ static int load_module(struct load_info *info, const char __user *uargs,
>  	mod_sysfs_teardown(mod);
>   coming_cleanup:
>  	mod->state = MODULE_STATE_GOING;
> +	destroy_params(mod->kp, mod->num_kp);
>  	blocking_notifier_call_chain(&module_notify_list,
>  				     MODULE_STATE_GOING, mod);
>  	klp_module_going(mod);
> -- 
> 2.10.1
>