From: Stuart Yoder <stuart.yoder@nxp.com>
To: Greg KH <gregkh@linuxfoundation.org>
CC: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "agraf@suse.de" <agraf@suse.de>, Leo Li <leoyang.li@nxp.com>,
        Catalin Horghidan <catalin.horghidan@nxp.com>,
        "Ioana Ciornei" <ioana.ciornei@nxp.com>,
        Laurentiu Tudor <laurentiu.tudor@nxp.com>
Subject: RE: [PATCH v3 1/9] staging: fsl-mc: move bus driver out of staging
Thread-Topic: [PATCH v3 1/9] staging: fsl-mc: move bus driver out of staging
Thread-Index: AQHSTCUaF8l5kM8cdUiKwJF2//8LNKD8q6AAgABAMICAAVWqAIAAhxjwgAB12YCAAJE1gA==
Date: Fri, 9 Dec 2016 15:53:27 +0000
Message-ID: <VI1PR0401MB263867BC07019BCAC48ABCE08D870@VI1PR0401MB2638.eurprd04.prod.outlook.com>
References: <1480632094-3621-1-git-send-email-stuart.yoder@nxp.com>
 <1480632094-3621-2-git-send-email-stuart.yoder@nxp.com>
 <20161207155248.GA11794@kroah.com>
 <VI1PR0401MB2638E11E4F86F3622FA0FAA28D850@VI1PR0401MB2638.eurprd04.prod.outlook.com>
 <20161208160524.GA4977@kroah.com>
 <VI1PR0401MB26386D1D87DD3136788DA0628D870@VI1PR0401MB2638.eurprd04.prod.outlook.com>
 <20161209071043.GA2940@kroah.com>
In-Reply-To: <20161209071043.GA2940@kroah.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2016 15:53:27.6374
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB1727
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uB9HPrwq022070
Content-Length: 1412
Lines: 39

> > > Where is the device freed?  I see you trying to do some "odd" stuff in
> > > fsl_mc_device_remove() by deleting and then putting a device structure.
> > > I can't find a "release()" callback anywhere for your bus, where is it?
> > >
> > > What happens when the reference count falls to 0 for your struct device?
> >
> > Hrm...something seems wrong in free path, and I think this needs to
> > be refactored.
> >
> > IIRC, when German (former maintainer) wrote that code he loosely based
> > it on the register/unregister platform bus code:
> >
> > int platform_device_register(struct platform_device *pdev)
> > {
> >         device_initialize(&pdev->dev);
> >         arch_setup_pdev_archdata(pdev);
> >         return platform_device_add(pdev);
> > }
> > void platform_device_unregister(struct platform_device *pdev)
> > {
> >         platform_device_del(pdev);
> >         platform_device_put(pdev);
> > }
> >
> > ...I'm puzzling over how that code handles a refcount of zero
> > as I see no 'release' callback anywhere, but I must be missing
> > something.
> >
> > In any case, we'll get this refactored.
> 
> Have you tried removing a device?  The kernel should complain loudly
> about there not being a release function for your device.

Yes, device removal has been working from day 1.  A brief look
seems to indicate that the ref count never goes to zero, which
needs to be debugged.

Thanks,
Stuart