Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752851AbcLISBf (ORCPT ); Fri, 9 Dec 2016 13:01:35 -0500 Received: from mail-oi0-f66.google.com ([209.85.218.66]:33665 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751829AbcLISBe (ORCPT ); Fri, 9 Dec 2016 13:01:34 -0500 Date: Fri, 9 Dec 2016 12:01:32 -0600 From: Rob Herring To: Anup Patel Cc: Jassi Brar , Mark Rutland , Ray Jui , Scott Branden , Pramod KUMAR , Rob Rice , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH v2 2/2] dt-bindings: Add DT bindings info for FlexRM ring manager Message-ID: <20161209180132.lnpvwybnij5uykuq@rob-hp-laptop> References: <1480653536-5551-1-git-send-email-anup.patel@broadcom.com> <1480653536-5551-3-git-send-email-anup.patel@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1480653536-5551-3-git-send-email-anup.patel@broadcom.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1542 Lines: 45 On Fri, Dec 02, 2016 at 10:08:56AM +0530, Anup Patel wrote: > This patch adds device tree bindings document for the FlexRM > ring manager found on Broadcom iProc SoCs. > > Reviewed-by: Ray Jui > Reviewed-by: Scott Branden > Signed-off-by: Anup Patel > --- > .../bindings/mailbox/brcm,iproc-flexrm-mbox.txt | 60 ++++++++++++++++++++++ > 1 file changed, 60 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mailbox/brcm,iproc-flexrm-mbox.txt > > diff --git a/Documentation/devicetree/bindings/mailbox/brcm,iproc-flexrm-mbox.txt b/Documentation/devicetree/bindings/mailbox/brcm,iproc-flexrm-mbox.txt > new file mode 100644 > index 0000000..e81f116 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mailbox/brcm,iproc-flexrm-mbox.txt > @@ -0,0 +1,60 @@ [...] > +Example: > +-------- > +crypto_mbox: mbox@67000000 { > + compatible = "brcm,flexrm-mbox"; > + reg = <0x67000000 0x200000>; > + msi-parent = <&gic_its 0x7f00>; > + #mbox-cells = <3>; > +}; > + > +crypto_client { > + ... > + mboxes = <&crypto_mbox 0 0x1 0xffff>, > + <&crypto_mbox 1 0x1 0xffff>, > + <&crypto_mbox 16 0x1 0xffff>, > + <&crypto_mbox 17 0x1 0xffff>, > + <&crypto_mbox 30 0x1 0xffff>, > + <&crypto_mbox 31 0x1 0xffff>; The FlexRM part looks fine. I still don't understand what this node is. Is this a h/w block or just a list of mailboxes? What determines the mailbox channel numbers here? I need to see what the complete node looks like. Rob