Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752887AbcLIUCO (ORCPT ); Fri, 9 Dec 2016 15:02:14 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:35900 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750756AbcLIUCN (ORCPT ); Fri, 9 Dec 2016 15:02:13 -0500 Date: Fri, 9 Dec 2016 20:02:00 +0000 From: Russell King - ARM Linux To: Benjamin Gaignard Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robin.Murphy@arm.com, Catalin Marinas , arnd@arndb.de Subject: Re: [PATCH] nommu: allow mmap when !CONFIG_MMU Message-ID: <20161209200200.GN14217@n2100.armlinux.org.uk> References: <1480600080-30196-1-git-send-email-benjamin.gaignard@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1480600080-30196-1-git-send-email-benjamin.gaignard@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 800 Lines: 20 On Thu, Dec 01, 2016 at 02:48:00PM +0100, Benjamin Gaignard wrote: > commit ab6494f0c96f ("nommu: Add noMMU support to the DMA API") have > add CONFIG_MMU compilation flag but that prohibit to use dma_mmap_wc() > when the platform doesn't have MMU. > > This patch call vm_iomap_memory() in noMMU case to test if addresses > are correct and set wma->vm_flags rather than all return an error. ITYM vma. I think this is fine, but I've no way to know as I don't run nommu here... I've been hoping that others working on nommu would at least give an ack or something, but I guess not. So, please put it in the patch system, thanks. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.