Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753534AbcLIUEI (ORCPT <rfc822;w@1wt.eu>);
        Fri, 9 Dec 2016 15:04:08 -0500
Received: from victor.provo.novell.com ([137.65.250.26]:39963 "EHLO
        prv3-mh.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751563AbcLIUEG (ORCPT
        <rfc822;groupwise-linux-kernel@vger.kernel.org:0:0>);
        Fri, 9 Dec 2016 15:04:06 -0500
Message-ID: <1481313824.3358.38.camel@suse.com>
Subject: Re: [RFC 10/10] kmod: add a sanity check on module loading
From: Martin Wilck <mwilck@suse.com>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>, shuah@kernel.org,
        jeyu@redhat.com, rusty@rustcorp.com.au, ebiederm@xmission.com,
        dmitry.torokhov@gmail.com, acme@redhat.com, corbet@lwn.net
Cc: martin.wilck@suse.com, mmarek@suse.com, pmladek@suse.com,
        hare@suse.com, rwright@hpe.com, jeffm@suse.com, DSterba@suse.com,
        fdmanana@suse.com, neilb@suse.com, linux@roeck-us.net,
        rgoldwyn@suse.com, subashab@codeaurora.org, xypron.glpk@gmx.de,
        keescook@chromium.org, atomlin@redhat.com, mbenes@suse.cz,
        paulmck@linux.vnet.ibm.com, dan.j.williams@intel.com,
        jpoimboe@redhat.com, davem@davemloft.net, mingo@redhat.com,
        akpm@linux-foundation.org, torvalds@linux-foundation.org,
        linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date: Fri, 09 Dec 2016 21:03:44 +0100
In-Reply-To: <20161208194930.2816-1-mcgrof@kernel.org>
References: <20161208184801.1689-1-mcgrof@kernel.org>
         <20161208194930.2816-1-mcgrof@kernel.org>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.22.2 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 632
Lines: 17

On Thu, 2016-12-08 at 11:49 -0800, Luis R. Rodriguez wrote:
> 
> Although this does get us in the business of keeping alias maps in
> kernel, the the work to support and maintain this is trivial.

You've implemented a special treatment for request_module("fs-$X")in
finished_kmod_load(), but there are many more aliases defined (and
used) in the kernel. Do you plan to implement special code for "char-
major-$X", "crypto-$X", "binfmt-$X" etc. later? 

Regards
Martin

-- 
Dr. Martin Wilck <mwilck@suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)