Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752763AbcLIUxm (ORCPT ); Fri, 9 Dec 2016 15:53:42 -0500 Received: from mx2.suse.de ([195.135.220.15]:47569 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751334AbcLIUxl (ORCPT ); Fri, 9 Dec 2016 15:53:41 -0500 Date: Fri, 09 Dec 2016 21:53:39 +0100 Message-ID: From: Takashi Iwai To: Con Kolivas Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH SND/USB]: Add QuickCam Communicate Deluxe/S7500 to volume_control_quirks. In-Reply-To: <3895233.t8xxWNsFQ1@hex> References: <2208242.ISe40cRj8e@hex> <3895233.t8xxWNsFQ1@hex> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1331 Lines: 38 On Fri, 09 Dec 2016 21:35:17 +0100, Con Kolivas wrote: > > On Friday, 9 December 2016 11:22:15 AM AEDT Takashi Iwai wrote: > > On Fri, 09 Dec 2016 05:15:57 +0100, > > > > Con Kolivas wrote: > > > The Logitech QuickCam Communicate Deluxe/S7500 microphone fails with the > > > following warning. > > > > > > [ 6.778995] usb 2-1.2.2.2: Warning! Unlikely big volume range (=3072), > > > cval->res is probably wrong. > > > [ 6.778996] usb 2-1.2.2.2: [5] FU [Mic Capture Volume] ch = 1, val = > > > 4608/7680/1 > > > > > > Adding it to the list of devices in volume_control_quirks makes it work > > > properly, fixing related typo. > > > > > > Signed-off-by: Con Kolivas > > > > Applied (with Cc to stable), thanks. > > (Apologies for google mail defaulting to html, resending with a proper mail > client) > > You're welcome. As there appear to be a lot of these devices from the same > manufacturer with the same error, and there are likely a lot of devices out > there that are missed from this whitelist, do you think it would be worthwhile > changing the code to detect the combination of unlikely big volume range and > usb vendor of 0x046d and automatically try using the volume_control_quirk on > them instead of a discrete whitelist? Yeah, it sounds like a good idea! thanks, Takashi