Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752966AbcLJIkr convert rfc822-to-8bit (ORCPT ); Sat, 10 Dec 2016 03:40:47 -0500 Received: from szxga03-in.huawei.com ([45.249.212.189]:2431 "EHLO dggrg03-dlp.huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752513AbcLJIkq (ORCPT ); Sat, 10 Dec 2016 03:40:46 -0500 From: "Gonglei (Arei)" To: Sam Ravnborg CC: "linux-kernel@vger.kernel.org" , "qemu-devel@nongnu.org" , "virtio-dev@lists.oasis-open.org" , "virtualization@lists.linux-foundation.org" , "linux-crypto@vger.kernel.org" , Luonengjun , "mst@redhat.com" , "stefanha@redhat.com" , "Huangweidong (C)" , "Wubin (H)" , "xin.zeng@intel.com" , Claudio Fontana , "herbert@gondor.apana.org.au" , "pasic@linux.vnet.ibm.com" , "davem@davemloft.net" , "Zhoujian (jay, Euler)" , "Hanweidong (Randy)" , "arei.gonglei@hotmail.com" , "cornelia.huck@de.ibm.com" , "Xuquan (Quan Xu)" , longpeng , "Wanzongshun (Vincent)" , "sparclinux@vger.kernel.org" Subject: RE: [PATCH v6 1/2] sparc: fix a building error reported by kbuild Thread-Topic: [PATCH v6 1/2] sparc: fix a building error reported by kbuild Thread-Index: AQHSUQzH0rBYqWNjBEaNpKUUQMPfX6D/pqSAgAE2oKA= Date: Sat, 10 Dec 2016 08:40:02 +0000 Message-ID: <33183CC9F5247A488A2544077AF19020DA159386@DGGEMA505-MBX.china.huawei.com> References: <1481171829-116496-1-git-send-email-arei.gonglei@huawei.com> <1481171829-116496-2-git-send-email-arei.gonglei@huawei.com> <20161209215851.GA7717@ravnborg.org> In-Reply-To: <20161209215851.GA7717@ravnborg.org> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.177.18.62] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090206.584BBF74.004A,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=169.254.1.226, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 36f46d95f306950ca471de29627261b0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2474 Lines: 75 Regards, -Gonglei > -----Original Message----- > From: linux-crypto-owner@vger.kernel.org > [mailto:linux-crypto-owner@vger.kernel.org] On Behalf Of Sam Ravnborg > Sent: Saturday, December 10, 2016 5:59 AM > To: Gonglei (Arei) > Cc: linux-kernel@vger.kernel.org; qemu-devel@nongnu.org; > virtio-dev@lists.oasis-open.org; virtualization@lists.linux-foundation.org; > linux-crypto@vger.kernel.org; Luonengjun; mst@redhat.com; > stefanha@redhat.com; Huangweidong (C); Wubin (H); xin.zeng@intel.com; > Claudio Fontana; herbert@gondor.apana.org.au; pasic@linux.vnet.ibm.com; > davem@davemloft.net; Zhoujian (jay, Euler); Hanweidong (Randy); > arei.gonglei@hotmail.com; cornelia.huck@de.ibm.com; Xuquan (Quan Xu); > longpeng; Wanzongshun (Vincent); sparclinux@vger.kernel.org > Subject: Re: [PATCH v6 1/2] sparc: fix a building error reported by kbuild > > Hi Gonglei. > > On Thu, Dec 08, 2016 at 12:37:08PM +0800, Gonglei wrote: > > >> arch/sparc/include/asm/topology_64.h:44:44: > > error: implicit declaration of function 'cpu_data' > > [-Werror=implicit-function-declaration] > > > > #define topology_physical_package_id(cpu) (cpu_data(cpu).proc_id) > > ^ > > Let's include cpudata.h in topology_64.h. > > > > Cc: Sam Ravnborg > > Cc: David S. Miller > > Cc: sparclinux@vger.kernel.org > > Suggested-by: Sam Ravnborg > > Signed-off-by: Gonglei > Acked-by: Sam Ravnborg > Thanks. > > --- > > arch/sparc/include/asm/topology_64.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/sparc/include/asm/topology_64.h > b/arch/sparc/include/asm/topology_64.h > > index 7b4898a..2255430 100644 > > --- a/arch/sparc/include/asm/topology_64.h > > +++ b/arch/sparc/include/asm/topology_64.h > > @@ -4,6 +4,7 @@ > > #ifdef CONFIG_NUMA > > > > #include > > +#include > > Nitpick - if you are going to resend this patch, It depends on the maintainer's thought. :) > then please order the two includes in alphabetic order. > > For two includes this looks like bikeshedding, but when we add > more having them in a defined arder prevents merge conflicts. > And makes it readable too. > > We also sometimes order the includes with the longest lines topmost, > and lines with the ame length are ordered alphabetically. > But this is not seen so often. > Regards, -Gonglei