From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: daniel@zonque.org, haojian.zhuang@gmail.com, linus.walleij@linaro.org,
        linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions
References: <1481207730-6332-1-git-send-email-arvind.yadav.cs@gmail.com>
Date: Sat, 10 Dec 2016 10:19:07 +0100
In-Reply-To: <1481207730-6332-1-git-send-email-arvind.yadav.cs@gmail.com>
        (Arvind Yadav's message of "Thu, 8 Dec 2016 20:05:30 +0530")
Message-ID: <87eg1g16r8.fsf@belgarion.home>
User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 702
Lines: 21

Arvind Yadav <arvind.yadav.cs@gmail.com> writes:

Hi Arvind,

> In functions pxa2xx_build_functions, the memory allocated for
> 'functions' is live within the function only. After the
> allocation it is immediately freed with devm_kfree. There is
> no need to allocate memory for 'functions' with devm function
> so replace devm_kcalloc  with kcalloc and devm_kfree with kfree.

That's not very true : the "need" is to spare the "manual" kfree you're adding
in your patch for one, and make it consistent with pxa2xx_build_groups() and
pxa2xx_build_state() for two.

Therefore I'm not very thrilled by this patch and unless it fixes a defect in
the driver I'd rather not have it in.

Cheers.

--
Robert