Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752335AbcLJSQp (ORCPT ); Sat, 10 Dec 2016 13:16:45 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:57670 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751902AbcLJSQn (ORCPT ); Sat, 10 Dec 2016 13:16:43 -0500 Date: Sat, 10 Dec 2016 19:16:49 +0100 From: Greg Kroah-Hartman To: James Simmons Cc: devel@driverdev.osuosl.org, Andreas Dilger , Oleg Drokin , James Simmons , Linux Kernel Mailing List , Lustre Development List Subject: Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder functions in lustre_idl.h Message-ID: <20161210181649.GB8477@kroah.com> References: <1481393161-22623-1-git-send-email-jsimmons@infradead.org> <1481393161-22623-6-git-send-email-jsimmons@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1481393161-22623-6-git-send-email-jsimmons@infradead.org> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 567 Lines: 16 On Sat, Dec 10, 2016 at 01:06:01PM -0500, James Simmons wrote: > In order for lustre_idl.h to be usable for both user > land and kernel space it has to use the proper > byteorder functions. Why would userspace need/want all of these inline functions? A uapi header file should just have a the structures that are passed user/kernel and any needed ioctls. Why would they ever care about strange byte flip functions and a ton of inline functions? I don't think this is needed, of if it is, I really don't want to see your crazy userspace code... thanks, greg k-h