Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753322AbcLJWar (ORCPT ); Sat, 10 Dec 2016 17:30:47 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:58478 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752963AbcLJWap (ORCPT ); Sat, 10 Dec 2016 17:30:45 -0500 Date: Sat, 10 Dec 2016 17:30:44 -0500 (EST) Message-Id: <20161210.173044.1580240100890445540.davem@davemloft.net> To: ivan.khoronzhuk@linaro.org Cc: mugunthanvnm@ti.com, grygorii.strashko@ti.com, linux-omap@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] net: ethernet: ti: cpsw: combine budget and weight split and check From: David Miller In-Reply-To: <1481372630-14914-4-git-send-email-ivan.khoronzhuk@linaro.org> References: <1481372630-14914-1-git-send-email-ivan.khoronzhuk@linaro.org> <1481372630-14914-4-git-send-email-ivan.khoronzhuk@linaro.org> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 10 Dec 2016 13:31:24 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 420 Lines: 11 From: Ivan Khoronzhuk Date: Sat, 10 Dec 2016 14:23:48 +0200 > Re-split weight along with budget. It simplify code a little > and update state after every rate change. Also it's necessarily > to move arguments checks to this combined function. Replace > maximum rate check for an interface on maximum possible rate. > > Signed-off-by: Ivan Khoronzhuk Applied.