Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753033AbcLKCj2 (ORCPT ); Sat, 10 Dec 2016 21:39:28 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:50316 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751729AbcLKCj0 (ORCPT ); Sat, 10 Dec 2016 21:39:26 -0500 Date: Sun, 11 Dec 2016 02:39:05 +0000 From: Al Viro To: Miklos Szeredi Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org Subject: Re: [GIT PULL] readlink cleanup Message-ID: <20161211023902.GA24547@ZenIV.linux.org.uk> References: <20161210204145.GK2622@veci.piliscsaba.szeredi.hu> <20161211023620.GL1555@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161211023620.GL1555@ZenIV.linux.org.uk> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 381 Lines: 8 On Sun, Dec 11, 2016 at 02:36:20AM +0000, Al Viro wrote: > I'm still not sure what does "vfs: convert ->readlink to same signature as > ->get_link" buy us. If anything, the result appears to be more complex - > you make freeing that buffer delayed (and introduce a dynamically allocated > buffer in one case that didn't use it)... PS: everything prior to that point looks fine.