Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752517AbcLKKpn (ORCPT ); Sun, 11 Dec 2016 05:45:43 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35279 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751674AbcLKKpl (ORCPT ); Sun, 11 Dec 2016 05:45:41 -0500 From: Pali =?utf-8?q?Roh=C3=A1r?= To: Jacek Anaszewski , mario.limonciello@dell.com Subject: Re: [PATCH 0/7] Move dell-led to drivers/platform/x86 Date: Sun, 11 Dec 2016 11:45:37 +0100 User-Agent: KMail/1.13.7 (Linux/3.13.0-105-generic; KDE/4.14.2; x86_64; ; ) Cc: =?utf-8?q?Micha=C5=82_K=C4=99pie=C5=84?= , Richard Purdie , Matthew Garrett , Darren Hart , Jaroslav Kysela , Takashi Iwai , Louis Davis , Jim Dailey , Alex Hung , Hui Wang , linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <20161208123618.28603-1-kernel@kempniu.pl> <327c8edc-5a1e-8a94-85b2-4a2febc03352@samsung.com> In-Reply-To: <327c8edc-5a1e-8a94-85b2-4a2febc03352@samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart9382632.rKynATlCas"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201612111145.37777@pali> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4446 Lines: 106 --nextPart9382632.rKynATlCas Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Thursday 08 December 2016 15:26:37 Jacek Anaszewski wrote: > Hi Micha=C5=82, >=20 > Thanks for the patch set. >=20 > On 12/08/2016 01:36 PM, Micha=C5=82 K=C4=99pie=C5=84 wrote: > > This patch series moves the dell-led driver from the LED subsystem > > to the x86 platform driver subsystem. I decided to also CC the > > sound subsystem contacts for the whole series as > > sound/pci/hda/dell_wmi_helper.c is also affected. > >=20 > > The original motivation behind this effort was to move all code > > using the dell-smbios module to the x86 platform driver subsystem. > > While I was investigating the possibilites to do that, it quickly > > emerged that dell-led can and in fact should be moved to the x86 > > platform driver subsystem in its entirety. > >=20 > > dell-led consists of two major parts: > > - the part exposing a microphone mute LED interface, introduced > > in > > =20 > > db6d8cc ("dell-led: add mic mute led interface"); this > > interface is used by sound/pci/hda/dell_wmi_helper.c; while > > the original implementation used a WMI interface, it was > > changed to use dell-smbios in cf0d7ea ("dell-led: use > > dell_smbios_find_token() for finding mic DMI tokens") and > > 0c41a08 ("dell-led: use > > dell_smbios_send_request() for performing SMBIOS calls"), > > =20 > > - the part handling an activity LED present in Dell Latitude 2100 > > =20 > > netbooks, introduced in 72dcd8d ("leds: Add Dell Business Class > > Netbook LED driver"); it binds to a specific WMI GUID and then > > registers a LED device which is controlled using WMI (i.e. it > > is basically a WMI driver). > >=20 > > Patches 1-4 clean up the microphone mute LED interface to minimize > > the amount of code moved around. > >=20 > > Patch 5 moves the microphone mute LED interface to > > drivers/platform/x86/dell-laptop.c, effectively causing > > sound/pci/hda/dell_wmi_helper.c to depend on CONFIG_DELL_LAPTOP > > instead of CONFIG_LEDS_DELL_NETBOOKS. > >=20 > > Patch 6 reverts dell-led to the state it was in after its initial > > commit 72dcd8d ("leds: Add Dell Business Class Netbook LED > > driver") by removing all remnants of the microphone mute LED > > handling code. > >=20 > > Patch 7 moves all that is left of dell-led (i.e. the activity LED > > part, as originally implemented), to a new module which is placed > > in drivers/platform/x86/dell-wmi-led.c. > >=20 > > This patch series is based on linux-leds/for-4.11 as the LED > > subsystem is affected by all patches except patch 3. > >=20 > > If anyone reading this has access to a Dell device which has an > > activity LED and/or a microphone mute LED currently supported by > > dell-led, I would love to hear from you as I do not have the > > hardware needed to practically test this patch series. >=20 > I think that it is necessary to find someone who will give their > Tested-by. >=20 > What I can accept immediately is moving the driver in the current > shape to x86 platform drivers. I could expose a stable branch with > that patch for the x86 platform maintainers then. Adding Mario Limonciello from @dell to discussion. Mario, any chance you could be able to test this patch series? > > drivers/leds/Kconfig | 9 --- > > drivers/leds/Makefile | 1 - > > drivers/platform/x86/Kconfig | 8 +++ > > drivers/platform/x86/Makefile | 1 + > > drivers/platform/x86/dell-laptop.c | 28 ++++++++ > > .../dell-led.c =3D> platform/x86/dell-wmi-led.c} | 75 > > +++------------------- include/linux/dell-led.h =20 > > | 6 +- sound/pci/hda/dell_wmi_helper.c =20 > > | 18 +++--- 8 files changed, 55 insertions(+), 91 deletions(-) > > rename drivers/{leds/dell-led.c =3D> platform/x86/dell-wmi-led.c} > > (73%) =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart9382632.rKynATlCas Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlhNLlEACgkQi/DJPQPkQ1IcQACgpW6xP38Wv7FV6PzQVSp+Cudj 4MkAn0wsnppyy5pYIM3sZkyMPWWzrNQJ =iluJ -----END PGP SIGNATURE----- --nextPart9382632.rKynATlCas--