Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753623AbcLKQlj (ORCPT ); Sun, 11 Dec 2016 11:41:39 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:35214 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753367AbcLKQli (ORCPT ); Sun, 11 Dec 2016 11:41:38 -0500 From: Arvind Yadav To: a.zummo@towertech.it, alexandre.belloni@free-electrons.com Cc: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: [V1] rtc:rtc-vr41xx :- Retunr error is not correct in rtc_probe Date: Sun, 11 Dec 2016 22:11:24 +0530 Message-Id: <1481474484-1316-1-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1397 Lines: 55 Here, rtc_probe is returning EBUSY at any error case. It should return ENOMEM insted of EBUSY. -EBUSY A resource you need is not avaialable. -ENOMEM This is used to signify lack of memory resources. -ENODEV This is used when no device is available. Signed-off-by: Arvind Yadav --- drivers/rtc/rtc-vr41xx.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-vr41xx.c b/drivers/rtc/rtc-vr41xx.c index e1b86bb..e666d8e 100644 --- a/drivers/rtc/rtc-vr41xx.c +++ b/drivers/rtc/rtc-vr41xx.c @@ -292,21 +292,21 @@ static int rtc_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (!res) - return -EBUSY; + return -ENOMEM; rtc1_base = devm_ioremap(&pdev->dev, res->start, resource_size(res)); if (!rtc1_base) - return -EBUSY; + return -ENOMEM; res = platform_get_resource(pdev, IORESOURCE_MEM, 1); if (!res) { - retval = -EBUSY; + retval = -ENOMEM; goto err_rtc1_iounmap; } rtc2_base = devm_ioremap(&pdev->dev, res->start, resource_size(res)); if (!rtc2_base) { - retval = -EBUSY; + retval = -ENOMEM; goto err_rtc1_iounmap; } @@ -342,7 +342,7 @@ static int rtc_probe(struct platform_device *pdev) pie_irq = platform_get_irq(pdev, 1); if (pie_irq <= 0) { - retval = -EBUSY; + retval = -ENODEV; goto err_iounmap_all; } -- 2.7.4