Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753847AbcLKTOT (ORCPT ); Sun, 11 Dec 2016 14:14:19 -0500 Received: from mail-ua0-f177.google.com ([209.85.217.177]:35341 "EHLO mail-ua0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753817AbcLKTOR (ORCPT ); Sun, 11 Dec 2016 14:14:17 -0500 MIME-Version: 1.0 In-Reply-To: <20161209230851.GB64048@google.com> References: <20161209230851.GB64048@google.com> From: Andy Lutomirski Date: Sun, 11 Dec 2016 11:13:55 -0800 Message-ID: Subject: Re: Remaining crypto API regressions with CONFIG_VMAP_STACK To: Eric Biggers Cc: linux-crypto@vger.kernel.org, "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "kernel-hardening@lists.openwall.com" , Herbert Xu , Andrew Lutomirski , Stephan Mueller Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 480 Lines: 12 On Fri, Dec 9, 2016 at 3:08 PM, Eric Biggers wrote: > In the 4.9 kernel, virtually-mapped stacks will be supported and enabled by > default on x86_64. This has been exposing a number of problems in which > on-stack buffers are being passed into the crypto API, which to support crypto > accelerators operates on 'struct page' rather than on virtual memory. > > fs/cifs/smbencrypt.c:96 This should use crypto_cipher_encrypt_one(), I think. --Andy