Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753813AbcLKTbV (ORCPT <rfc822;w@1wt.eu>);
        Sun, 11 Dec 2016 14:31:21 -0500
Received: from shards.monkeyblade.net ([184.105.139.130]:44826 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753457AbcLKTbU (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 11 Dec 2016 14:31:20 -0500
Date: Sun, 11 Dec 2016 14:31:13 -0500 (EST)
Message-Id: <20161211.143113.268450274785467682.davem@davemloft.net>
To: pavel@ucw.cz
Cc: peppe.cavallaro@st.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, alexandre.torgue@st.com,
        LinoSanfilippo@gmx.de
Subject: Re: [PATCH] stmmac: disable tx coalescing
From: David Miller <davem@davemloft.net>
In-Reply-To: <20161211190750.GA14287@amd>
References: <20161124.110416.198867271899443489.davem@davemloft.net>
        <20161205122711.GA30774@amd>
        <20161211190750.GA14287@amd>
X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 11 Dec 2016 10:31:56 -0800 (PST)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 425
Lines: 11

From: Pavel Machek <pavel@ucw.cz>
Date: Sun, 11 Dec 2016 20:07:50 +0100

> David, ping? Can I get you to apply this one?
> 
> As you noticed, tx coalescing is completely broken in that driver, and
> not easy to repair. This is simplest way to disable it. It can still
> be re-enabled from userspace, so code can be fixed in future.

Sorry I'm not applying this, I want you and the driver maintainer
to reach a real solution.